Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datatables pagination #3702

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Datatables pagination #3702

wants to merge 1 commit into from

Conversation

ddrury
Copy link
Contributor

@ddrury ddrury commented Feb 1, 2021

I know you don't like this but...

By changing the first/last/next/previous paging text to symbols and rearranging the controls slightly, the space saved allows the provision of the pagination & display controls on both header & footer of a list without increasing the overall table size. This is useful when viewing a long table (for example the media list on the control panel)

demo

@reteP-riS
Copy link

I support this idea, but it seems - at least from above screenshot - that the "Showing x to y of z" records information is missing. In the original lists this information is in the lower left corner of the table.

@ddrury
Copy link
Contributor Author

ddrury commented Mar 1, 2021

@reteP-riS

"Showing x to y of z"

Bottom centre

@reteP-riS
Copy link

I withdraw my comment and state the opposite.... Thanks!

@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #3702 (9a866cb) into main (3d0b7ee) will decrease coverage by 0.76%.
The diff coverage is n/a.

❗ Current head 9a866cb differs from pull request most recent head 8140521. Consider uploading reports for the commit 8140521 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3702      +/-   ##
============================================
- Coverage     24.43%   23.67%   -0.77%     
- Complexity    11203    12001     +798     
============================================
  Files          1616     1073     -543     
  Lines         47984    44391    -3593     
============================================
- Hits          11727    10510    -1217     
+ Misses        36257    33881    -2376     
Impacted Files Coverage Δ
app/Module/LanguageFrench.php 0.00% <0.00%> (-100.00%) ⬇️
app/Census/CensusColumnReligion.php 0.00% <0.00%> (-100.00%) ⬇️
app/Module/LanguageEnglishGreatBritain.php 0.00% <0.00%> (-100.00%) ⬇️
app/Module/LanguageEnglishUnitedStates.php 0.00% <0.00%> (-100.00%) ⬇️
app/Census/CensusColumnBirthDayMonthYear.php 0.00% <0.00%> (-100.00%) ⬇️
app/Census/CensusColumnBirthDaySlashMonth.php 0.00% <0.00%> (-100.00%) ⬇️
app/Census/CensusColumnBirthDayDotMonthYear.php 0.00% <0.00%> (-100.00%) ⬇️
app/Census/CensusColumnBirthDaySlashMonthYear.php 0.00% <0.00%> (-100.00%) ⬇️
app/Census/Census.php 23.17% <0.00%> (-76.83%) ⬇️
app/Services/EmailService.php 0.00% <0.00%> (-69.57%) ⬇️
... and 1219 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d0b7ee...8140521. Read the comment docs.

Base automatically changed from master to main March 11, 2021 07:40
…st, changed paging text to symbols,

Fix syntax error vendor.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants