Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

views\lists\datatables-attributes - a suggestion #3445

Closed
ddrury opened this issue Jul 28, 2020 · 2 comments
Closed

views\lists\datatables-attributes - a suggestion #3445

ddrury opened this issue Jul 28, 2020 · 2 comments

Comments

@ddrury
Copy link
Contributor

ddrury commented Jul 28, 2020

For the pagination control, translations are provided for "first" & "last" buttons, however these aren't used.

My suggestion is to provide an extra line to the file data-paging-type="full_numbers", however I accept that in situations with a lot of pages this can result in an overly long control. I suppose rather than text the character equivalents of "<<", "<", ">", ">>" could be used

demo

@fisharebest
Copy link
Owner

The existing pagination control shows the first and last page (by number) - 1 and 90 in this case.

So, they are not really needed here?

I think other pagination options don't include the end pages - and so first/last buttons may be useful in those cases.

@ddrury
Copy link
Contributor Author

ddrury commented Mar 5, 2021

With my PR (#3702) I made an executive decision and went with icons and full numbers. If, as I suspect, you're not going with the PR then stick with things as they are.

@ddrury ddrury closed this as completed Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants