New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isolate sudo
usage
#1671
Isolate sudo
usage
#1671
Conversation
Update local bitstream(s) for PR #1671 (`sudo-once`)
All simulations are now verified. On merge, I'll squash/rebase the PR. |
...tting-Started-Guides/On-Premises-FPGA-Getting-Started/Initial-Setup/Xilinx-XDMA-Template.rst
Outdated
Show resolved
Hide resolved
...tting-Started-Guides/On-Premises-FPGA-Getting-Started/Initial-Setup/Xilinx-XDMA-Template.rst
Outdated
Show resolved
Hide resolved
...tting-Started-Guides/On-Premises-FPGA-Getting-Started/Initial-Setup/Xilinx-XDMA-Template.rst
Outdated
Show resolved
Hide resolved
...tting-Started-Guides/On-Premises-FPGA-Getting-Started/Initial-Setup/Xilinx-XDMA-Template.rst
Outdated
Show resolved
Hide resolved
…nitial-Setup/Xilinx-XDMA-Template.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should we DRY out /usr/local/bin
throughout the manager?
Otherwise LGTM!
Sure. I was just lazy and haven't done that. |
Ping @sagark |
I've gotten an offline approval from @sagark on this PR. I will merge on CI passes on this. |
Great stuff! Thanks for cleaning it up. |
Eventually, we want to make FireSim not depend on
sudo
, and if it does, then it should only dosudo
operations during system setup (i.e. when installing FPGAs). This will isolate the spread ofsudo
throughout the codebase and instead focus it on a few functions. This will allow local setups to not depend on passwordless sudo (which generally isn't a good practice).For non-AWS setups, there is now a "sysadmin" step where you install FireSim scripts to
/usr/local/bin
that are used by the manager. This PR does the following:sudo
is removed in as many places as possible (really only needed during AWS now)Misc. TODO:
deploy/sudo-scripts/README
Related PRs / Issues
UI / API Impact
Verilog / AGFI Compatibility
Contributor Checklist
changelog:<topic>
label?ci:fpga-deploy
label?Please Backport
label?Reviewer Checklist (only modified by reviewer)
Note: to run CI on PRs from forks, comment
@Mergifyio copy main
and manage the change from the new PR.changelog:<topic>
label?