New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Verilog macro helpers to reduce duplication #1710
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abejgonzalez
changed the title
Add helpers to reduce duplication
Add Verilog macro helpers to reduce duplication
Mar 26, 2024
abejgonzalez
added
changelog:changed
Put PR title in 'Changed' section of changelog
ci:local-fpga-buildbitstream-deploy
labels
Mar 27, 2024
abejgonzalez
commented
Apr 1, 2024
platforms/xilinx_alveo_u250/cl_firesim/design/overall_fpga_top.v
Outdated
Show resolved
Hide resolved
abejgonzalez
commented
Apr 1, 2024
platforms/xilinx_alveo_u250/cl_firesim/design/overall_fpga_top.v
Outdated
Show resolved
Hide resolved
abejgonzalez
force-pushed
the
helpers
branch
2 times, most recently
from
April 14, 2024 21:52
43bf4c2
to
f119411
Compare
TODO: Change to be based on |
abejgonzalez
added
ci:fpga-deploy
and removed
ci:local-fpga-buildbitstream-deploy
labels
Apr 15, 2024
abejgonzalez
added a commit
that referenced
this pull request
Apr 15, 2024
Update local bitstream(s) for PR #1710 (`helpers`)
@Mergifyio rebase main |
✅ Branch has been successfully rebased |
joonho3020
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff.
I would prefer defining all the macros in a single fpga_top_macros.vh
file, but this seems fine as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Verilog macros to instantiate wires/ports/etc in the Verilog sections of FireSim.
TL;DR: Writing Verilog without bundle connects is hard. Instead, I made AXI macros for it! Now Verilog is easy!
Related PRs / Issues
UI / API Impact
Verilog / AGFI Compatibility
Contributor Checklist
changelog:<topic>
label?ci:fpga-deploy
label?Please Backport
label?Reviewer Checklist (only modified by reviewer)
Note: to run CI on PRs from forks, comment
@Mergifyio copy main
and manage the change from the new PR.changelog:<topic>
label?