Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Verilog macro helpers to reduce duplication #1710

Merged
merged 2 commits into from Apr 30, 2024
Merged

Add Verilog macro helpers to reduce duplication #1710

merged 2 commits into from Apr 30, 2024

Conversation

abejgonzalez
Copy link
Contributor

Use Verilog macros to instantiate wires/ports/etc in the Verilog sections of FireSim.

TL;DR: Writing Verilog without bundle connects is hard. Instead, I made AXI macros for it! Now Verilog is easy!

Related PRs / Issues

UI / API Impact

Verilog / AGFI Compatibility

Contributor Checklist

  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you add Scaladoc/docstring/doxygen to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous prints/debugging code?
  • Did you state the UI / API impact?
  • Did you specify the Verilog / AGFI compatibility impact?
  • If applicable, did you regenerate and publicly share default AGFIs?
  • If applicable, did you apply the ci:fpga-deploy label?
  • If applicable, did you apply the Please Backport label?

Reviewer Checklist (only modified by reviewer)

Note: to run CI on PRs from forks, comment @Mergifyio copy main and manage the change from the new PR.

  • Is the title suitable for inclusion in the changelog and does the PR have a changelog:<topic> label?
  • Did you mark the proper release milestone?
  • Did you check whether all relevant Contributor checkboxes have been checked?

@abejgonzalez abejgonzalez changed the title Add helpers to reduce duplication Add Verilog macro helpers to reduce duplication Mar 26, 2024
@abejgonzalez abejgonzalez added changelog:changed Put PR title in 'Changed' section of changelog ci:local-fpga-buildbitstream-deploy labels Mar 27, 2024
@abejgonzalez
Copy link
Contributor Author

TODO: Change to be based on main on #1671 is done.

@abejgonzalez
Copy link
Contributor Author

@Mergifyio rebase main

Copy link
Contributor

mergify bot commented Apr 30, 2024

rebase main

✅ Branch has been successfully rebased

Copy link
Contributor

@joonho3020 joonho3020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff.
I would prefer defining all the macros in a single fpga_top_macros.vh file, but this seems fine as well.

@abejgonzalez abejgonzalez merged commit 740e6d7 into main Apr 30, 2024
1 check passed
@abejgonzalez abejgonzalez deleted the helpers branch April 30, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:changed Put PR title in 'Changed' section of changelog ci:fpga-deploy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants