Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff ABT Experiments for real-time RC #12236

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Diff ABT Experiments for real-time RC #12236

wants to merge 35 commits into from
+257 −3

Commits on May 9, 2023

  1. Add activated experiment metadata and payload keys to experiments table

    @qdpham13
    qdpham13 committed May 9, 2023
    Configuration menu
    Copy the full SHA
    f853b61 View commit details
    Browse the repository at this point in the history

  2. Call updateActivatedExperiments in activation method

    @qdpham13
    qdpham13 committed May 9, 2023
    Configuration menu
    Copy the full SHA
    9f1cea0 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Update key name for experiments table

    @qdpham13
    qdpham13 committed May 11, 2023
    Configuration menu
    Copy the full SHA
    ceae355 View commit details
    Browse the repository at this point in the history

  2. Update test to include activation call

    @qdpham13
    qdpham13 committed May 11, 2023
    Configuration menu
    Copy the full SHA
    e7b92b1 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Update DB manager for Active experiments payload and metadata

    @qdpham13
    qdpham13 committed May 12, 2023
    Configuration menu
    Copy the full SHA
    db6aff1 View commit details
    Browse the repository at this point in the history

  2. Fix metadata naming

    @qdpham13
    qdpham13 committed May 12, 2023
    Configuration menu
    Copy the full SHA
    5867edb View commit details
    Browse the repository at this point in the history

  3. add comment

    @qdpham13
    qdpham13 committed May 12, 2023
    Configuration menu
    Copy the full SHA
    c2b6097 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. Merge branch 'master'

    @qdpham13
    qdpham13 committed May 17, 2023
    Configuration menu
    Copy the full SHA
    d1b2349 View commit details
    Browse the repository at this point in the history

  2. Don't save experiments metadata b/c it isn't required to diff experim… 

    …ents
    @qdpham13
    qdpham13 committed May 17, 2023
    Configuration menu
    Copy the full SHA
    937630d View commit details
    Browse the repository at this point in the history

  3. Create diff method

    @qdpham13
    qdpham13 committed May 17, 2023
    Configuration menu
    Copy the full SHA
    d49bffb View commit details
    Browse the repository at this point in the history

  4. Adding diffing logic between fetched and activated experiments

    @qdpham13
    qdpham13 committed May 17, 2023
    Configuration menu
    Copy the full SHA
    0067548 View commit details
    Browse the repository at this point in the history

  5. formatting

    @qdpham13
    qdpham13 committed May 17, 2023
    Configuration menu
    Copy the full SHA
    d02b9e5 View commit details
    Browse the repository at this point in the history

  6. Refactor more of main diffing method

    @qdpham13
    qdpham13 committed May 17, 2023
    Configuration menu
    Copy the full SHA
    c9acee2 View commit details
    Browse the repository at this point in the history

  7. use ABT diffing in ConfigUpdate logic

    @qdpham13
    qdpham13 committed May 17, 2023
    Configuration menu
    Copy the full SHA
    8337c60 View commit details
    Browse the repository at this point in the history

  8. Add extra assertion for test

    @qdpham13
    qdpham13 committed May 17, 2023
    Configuration menu
    Copy the full SHA
    12be9c7 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'abt-exp-meta'

    @qdpham13
    qdpham13 committed May 17, 2023
    Configuration menu
    Copy the full SHA
    69d4061 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. Add tests

    @qdpham13
    qdpham13 committed May 18, 2023
    Configuration menu
    Copy the full SHA
    92efb59 View commit details
    Browse the repository at this point in the history

  2. Add in commenting

    @qdpham13
    qdpham13 committed May 18, 2023
    Configuration menu
    Copy the full SHA
    bac29da View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. Address PR comments

    @qdpham13
    qdpham13 committed May 24, 2023
    Configuration menu
    Copy the full SHA
    829d953 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. update naming

    @qdpham13
    qdpham13 committed May 26, 2023
    Configuration menu
    Copy the full SHA
    9a0f4e6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'abt-exp-meta' 

    Conflicts:
	FirebaseRemoteConfig/Sources/RCNConfigDBManager.m
	FirebaseRemoteConfig/Sources/RCNConfigExperiment.m
	FirebaseRemoteConfig/Tests/Unit/RCNConfigExperimentTest.m
    @qdpham13
    qdpham13 committed May 26, 2023
    Configuration menu
    Copy the full SHA
    bc78a5e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' 

    Conflicts:
	FirebaseRemoteConfig/Sources/RCNConfigExperiment.m
	FirebaseRemoteConfig/Tests/Unit/RCNConfigExperimentTest.m
    @qdpham13
    qdpham13 committed May 26, 2023
    Configuration menu
    Copy the full SHA
    707f5f1 View commit details
    Browse the repository at this point in the history

  4. formatting

    @qdpham13
    qdpham13 committed May 26, 2023
    Configuration menu
    Copy the full SHA
    0ce47b9 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. Update diffing logic

    @qdpham13
    qdpham13 committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    5166676 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master'

    @qdpham13
    qdpham13 committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    bf27372 View commit details
    Browse the repository at this point in the history

  3. format and add comments

    @qdpham13
    qdpham13 committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    756df3b View commit details
    Browse the repository at this point in the history

  4. Fix grammar

    @qdpham13
    qdpham13 committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    a1a01e6 View commit details
    Browse the repository at this point in the history

  5. Update comment

    @qdpham13
    qdpham13 committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    00d8284 View commit details
    Browse the repository at this point in the history

  6. Remove unused constant

    @qdpham13
    qdpham13 committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    693a2de View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. Move diffing logic to ConfigContainer

    @qdpham13
    qdpham13 committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    9275933 View commit details
    Browse the repository at this point in the history

  2. remove space

    @qdpham13
    qdpham13 committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    b68a3df View commit details
    Browse the repository at this point in the history

  3. Delete TestABTPayload2.txt

    @qdpham13
    qdpham13 committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    6dbc9c6 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master'

    @qdpham13
    qdpham13 committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    4e4f4d9 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'refs/remotes/origin/abt-exp-diff-2'

    @qdpham13
    qdpham13 committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    e365cce View commit details
    Browse the repository at this point in the history

  6. Make it easier to test

    @qdpham13
    qdpham13 committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    6e12a8c View commit details
    Browse the repository at this point in the history