Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff ABT Experiments for real-time RC #12236

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Diff ABT Experiments for real-time RC #12236

wants to merge 35 commits into from

Conversation

qdpham13
Copy link
Contributor

@qdpham13 qdpham13 commented Jan 3, 2024

Adds diffing logic between experiments fetched via real-time and experiments active on the device. The config keys that have been affected by the differences will be added to ConfigUpdate. Testing below:

Created experiments with https://docs.google.com/document/d/1MXxUg1JSBbh3m_Qy4tGPrGs3-Nh8FAwKmg5ZWOKQ3J8/edit

Add experiments to configs using Management API, example: https://rpc.corp.google.com/rpc/builder?rpcId=15352346049097272373

2.1) Add/Remove Experiment to Config Key.
2.2) Replace experiment in Config Key
2.3) Create new param with experiment attached

See changes in SDK

qdpham13 added 30 commits May 9, 2023 13:56
@qdpham13
Add activated experiment metadata and payload keys to experiments table
f853b61
@qdpham13
Call updateActivatedExperiments in activation method
9f1cea0
@qdpham13
Update key name for experiments table
ceae355
@qdpham13
Update test to include activation call
e7b92b1
@qdpham13
Update DB manager for Active experiments payload and metadata
db6aff1
@qdpham13
Fix metadata naming
5867edb
@qdpham13
add comment
c2b6097
@qdpham13
Merge branch 'master'
d1b2349
@qdpham13
Don't save experiments metadata b/c it isn't required to diff experim…
937630d 
…ents
@qdpham13
Create diff method
d49bffb
@qdpham13
Adding diffing logic between fetched and activated experiments
0067548
@qdpham13
formatting
d02b9e5
@qdpham13
Refactor more of main diffing method
c9acee2
@qdpham13
use ABT diffing in ConfigUpdate logic
8337c60
@qdpham13
Add extra assertion for test
12be9c7
@qdpham13
Merge branch 'abt-exp-meta'
69d4061
@qdpham13
Add tests
92efb59
@qdpham13
Add in commenting
bac29da
@qdpham13
Address PR comments
829d953
@qdpham13
update naming
9a0f4e6
@qdpham13
Merge branch 'abt-exp-meta'
bc78a5e 
Conflicts:
	FirebaseRemoteConfig/Sources/RCNConfigDBManager.m
	FirebaseRemoteConfig/Sources/RCNConfigExperiment.m
	FirebaseRemoteConfig/Tests/Unit/RCNConfigExperimentTest.m
@qdpham13
Merge branch 'master'
707f5f1 
Conflicts:
	FirebaseRemoteConfig/Sources/RCNConfigExperiment.m
	FirebaseRemoteConfig/Tests/Unit/RCNConfigExperimentTest.m
@qdpham13
formatting
0ce47b9
@qdpham13
Update diffing logic
5166676
@qdpham13
Merge branch 'master'
bf27372
@qdpham13
format and add comments
756df3b
@qdpham13
Fix grammar
a1a01e6
@qdpham13
Update comment
00d8284
@qdpham13
Remove unused constant
693a2de
@qdpham13
Move diffing logic to ConfigContainer
9275933
@qdpham13 qdpham13 changed the title Abt exp diff 2 Diff ABT Experiments for real-time RC Jan 3, 2024
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseRemoteConfig-iOS-FirebaseRemoteConfig.framework

    Overall coverage changed from 72.24% (0fe8385) to 72.67% (325b245) by +0.43%.

    FilenameBase (0fe8385)Merge (325b245)Diff
    RCNConfigContent.m81.90%85.64%+3.74%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/35TfgGDaQD.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: remoteconfig
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qdpham13 @google-oss-bot