fix: check for undefined options when validating

[mikejpeters]

Resolves #187

[codecov]

Codecov Report

Merging #188 (084f633) into master (c8c6953) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   85.26%   85.38%   +0.12%     
==========================================
  Files           6        6              
  Lines         346      349       +3     
==========================================
+ Hits          295      298       +3     
  Misses         51       51              

Impacted Files	Coverage Δ
lib/bucket-utils.js	96.66% <100.00%> (ø)
lib/validate.js	60.75% <100.00%> (+1.54%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[Shereef]

I will test this tomorrow But from the code review I think this changed the plug-in to stop sls deploy if `custom.client` is not defined I think this might be a breaking change for some people. I could be wrong getting a noob open source contribute what do you think Mike?

On Tue, May 2, 2023 at 12:26 AM codecov[bot] ***@***.***> wrote: Codecov <https://codecov.io/gh/fernando-mc/serverless-finch/pull/188?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fernando+Medina+Corey> Report Merging #188 <https://codecov.io/gh/fernando-mc/serverless-finch/pull/188?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fernando+Medina+Corey> (084f633 <084f633>) into master <https://codecov.io/gh/fernando-mc/serverless-finch/commit/c8c69534deff8a4452c0594acca728be64d97771?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fernando+Medina+Corey> (c8c6953 <c8c6953>) will *increase* coverage by 0.12%. The diff coverage is 100.00%. @@ Coverage Diff @@## master #188 +/- ## ==========================================+ Coverage 85.26% 85.38% +0.12% ========================================== Files 6 6 Lines 346 349 +3 ==========================================+ Hits 295 298 +3 Misses 51 51 Impacted Files <https://codecov.io/gh/fernando-mc/serverless-finch/pull/188?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fernando+Medina+Corey> Coverage Δ lib/bucket-utils.js <https://codecov.io/gh/fernando-mc/serverless-finch/pull/188?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fernando+Medina+Corey#diff-bGliL2J1Y2tldC11dGlscy5qcw==> 96.66% <100.00%> (ø) lib/validate.js <https://codecov.io/gh/fernando-mc/serverless-finch/pull/188?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fernando+Medina+Corey#diff-bGliL3ZhbGlkYXRlLmpz> 60.75% <100.00%> (+1.54%) ⬆️ 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more <https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fernando+Medina+Corey> — Reply to this email directly, view it on GitHub <#188 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACXDG7WPM5QS77CNYV3DPLXEB5EZANCNFSM6AAAAAAXSPODXQ> . You are receiving this because your review was requested.Message ID: ***@***.***>

-- Regards, Shereef Marzouk

[mikejpeters]

client.bucketName has always been required, and the current behavior is to crash with an unclear error if client is missing, so this doesn't actually change the ultimate behavior, just a clear message instead of an unclear error

[github-actions]

🎉 This PR is included in version 4.0.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀