fix: check for undefined options when validating

fernando-mc · May 2, 2023 · 4ab6e60 · 4ab6e60
1 parent 964f0b3
commit 4ab6e60
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/lib/validate.js b/lib/validate.js
@@ -12,6 +12,11 @@ const path = require('path');
 function validateClient(serverless, options) {
   const validationErrors = [];
 
+  if (!is.object(options)) {
+    validationErrors.push('Options must be an object defined under `custom.client`');
+    throw validationErrors;
+  }
+
   // path to website files must exist
   const distributionFolder = options.distributionFolder || path.join('client/dist');
   const clientPath = path.join(serverless.config.servicePath, distributionFolder);

diff --git a/lib/validate.test.js b/lib/validate.test.js
@@ -28,6 +28,16 @@ describe('validate', () => {
     expect(() => validate(sls, { bucketName: 'my-bucket' })).not.to.throw();
   });
 
+  it('throws if options are undefined', () => {
+    const sls = {
+      config: { servicePath: 'foo' },
+      utils: { dirExistsSync: () => true }
+    };
+    expect(() => validate(sls, undefined))
+      .to.throw()
+      .contains('Options must be an object defined under `custom.client`');
+  });
+
   it('throws if serverless.utils.dirExistsSync returns false', () => {
     const sls = {
       config: { servicePath: 'foo' },