Avoid validation warning when inputs change type #7333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhunzaker
force-pushed
the
nh-input-change-fix
branch
from
16dd9e1
to
1965cd9
Compare
|
Can we move textarea down too for consistency? And let's make it a switch for input/select/textarea. |
nhunzaker
force-pushed
the
nh-input-change-fix
branch
from
1965cd9
to
195e307
Compare
For controlled inputs, `updateWrapper` was getting called before the `type` prop had a chance to update. This could lead to a case where switching from the `text` to `number` type caused a validation error that would prevent the proper input value from being assigned. This commit moves the call to `ReactDOMInput.updateWrapper` below `_updateProperties` to avoid this situation.
nhunzaker
force-pushed
the
nh-input-change-fix
branch
from
195e307
to
8272e8f
Compare
ghost
added
GH Review: review-needed
CLA Signed
and removed
GH Review: needs-revision
labels
|
Done. I think this can also be patched right into |
|
Perfect, thanks! |
zpao
pushed a commit
that referenced
this pull request
Aug 12, 2016
For controlled inputs, `updateWrapper` was getting called before the `type` prop had a chance to update. This could lead to a case where switching from the `text` to `number` type caused a validation error that would prevent the proper input value from being assigned. This commit moves the call to `ReactDOMInput.updateWrapper` below `_updateProperties` to avoid this situation. (cherry picked from commit 08a0895)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For controlled inputs,
updateWrapperwas getting called before thetypeprop had a chance to update. This could lead to a case where switching from thetexttonumbertype caused a validation error that would prevent the proper input value from being assigned.This commit moves the call to
ReactDOMInput.updateWrapperbelow_updatePropertiesto avoid this situation.Fixes #6441.
Also worth mentioning: this does not fix #7144. It looks like Safari still doesn't like it when you change an input's type to file; period. That may require using a key, as others have suggested.