Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression with html5 inputs #80

Closed
serkandurusoy opened this issue Jul 20, 2016 · 5 comments
Closed

Regression with html5 inputs #80

serkandurusoy opened this issue Jul 20, 2016 · 5 comments
Assignees
Labels
Type: Bug Bug reports and their fixes

Comments

@serkandurusoy
Copy link
Contributor

serkandurusoy commented Jul 20, 2016

Here's the output on the console while I'm typing in some text into a text field which has type="email" prop on it.

image

We had a similar problem before which we discussed over at issue #22

@radekmie radekmie added the Type: Bug Bug reports and their fixes label Jul 20, 2016
@radekmie radekmie self-assigned this Jul 20, 2016
@radekmie
Copy link
Contributor

So I'll investigate it one more time.

@radekmie
Copy link
Contributor

I've spend some time to track this down and this turned out to be a React regression. Here are my results:

0.14.8         OK
15.0.0-rc.2    OK
15.0.0         3x
15.0.1         OK
15.0.2-alpha.1 OK
15.0.2-alpha.2 OK
15.0.2-alpha.3 OK
15.0.2-alpha.4 OK
15.0.2         OK
15.0.3-alpha.1 OK
15.0.3-alpha.2 OK
15.1.0-alpha.1 OK
15.1.0         OK
15.2.0-rc.1    1x
15.2.0-rc.2    1x
15.2.0         1x
15.2.1         1x
15.3.0-rc.1    1x
15.3.0-rc.2    1x
15.3.0-rc.3    1x

(1x - one warning, 3x - three warnings, OK - no warnings)

It's clearly a regression in 15.2.0-rc.1, so I've tried to see a diff between 15.1.0 and 15.2.0-rc.1. Then I learned, that React is not tagging their release candidates, so I've tried to diff 15.1.0 with 15.2.0. Well, it's something (it may freeze your browser). I don't really know, what to do now.

@serkandurusoy
Copy link
Contributor Author

Wow, nice work!

And I think these two are somewhat relevant to our case, the latter probably solving our case inadvertantly

facebook/react#6441
facebook/react#7333

@radekmie
Copy link
Contributor

Yes, kind of - I've even referred to them in my issue facebook/react#6992. Hope it will help (and get merged asap).

I'll close it for now, as it's not uniforms issue.

@radekmie
Copy link
Contributor

I've added a note in README about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug reports and their fixes
Projects
Archived in project
Development

No branches or pull requests

2 participants