Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable BasicFunctionUsedUnusedTwoRuntimes in Apple ASAN #1351

Open
wants to merge 1 commit into
base: static_h
Choose a base branch
from
Open

Disable BasicFunctionUsedUnusedTwoRuntimes in Apple ASAN #1351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions unittests/VMRuntime/CodeCoverageProfilerTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
#include "hermes/VM/Profiler/CodeCoverageProfiler.h"

#include "llvh/ADT/StringRef.h"
#include "llvh/Support/Compiler.h"
#include "llvh/Support/raw_ostream.h"

#include <algorithm>
Expand Down Expand Up @@ -116,6 +117,10 @@ TEST_F(CodeCoverageProfilerTest, BasicFunctionUsedUnused) {

// Right now, this just tests that we can simultaneously run two code coverage
// profilers.
// Disabled for Apple ASAN builds because it causes a native stack overflow
// as a result of the large minimum stack gap.
// Consider enabling it again with larger stack for std::async.
#if !(LLVM_ADDRESS_SANITIZER_BUILD && defined(__APPLE__))
TEST_F(CodeCoverageProfilerTest, BasicFunctionUsedUnusedTwoRuntimes) {
auto runtime2 = newRuntime();
GCScope scope{*runtime2};
Expand Down Expand Up @@ -159,6 +164,7 @@ TEST_F(CodeCoverageProfilerTest, BasicFunctionUsedUnusedTwoRuntimes) {
EXPECT_FALSE(isFuncExecuted(rt, executedFuncInfos, funcUnused));
}
}
#endif

TEST_F(CodeCoverageProfilerTest, FunctionsFromMultipleModules) {
hbc::CompileFlags flags;
Expand Down