Disable BasicFunctionUsedUnusedTwoRuntimes in Apple ASAN #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54917788 |
Summary: ASAN has a big minimum native stack gap, which causes this test to crash on mac under ASAN due to the use of `std::async.` Disable this test under ASAN on Mac. Differential Revision: D54917788
avp
force-pushed
the
export-D54917788-to-static_h
branch
from
79d2227
to
7be237d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54917788 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
Summary: Pull Request resolved: #1351 ASAN has a big minimum native stack gap, which causes this test to crash on mac under ASAN due to the use of `std::async.` Disable this test under ASAN on Mac. Reviewed By: neildhar Differential Revision: D54917788 fbshipit-source-id: f87b4855daeda89ce7f1437d874326eed36a4b50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
ASAN has a big minimum native stack gap, which causes this test to crash
on mac under ASAN due to the use of
std::async.Disable this test under ASAN on Mac.
Differential Revision: D54917788