Skip to content

Commit

Permalink
Migrate to Android 13.2
Browse files Browse the repository at this point in the history
Summary: Migrate Android SDK dependency to version 13.2.0

Reviewed By: Alaeldin513

Differential Revision: D36482392

fbshipit-source-id: 071a6a3b9b2119bc49e0ec4dcd95ad186d7600ff
  • Loading branch information
JarWarren authored and facebook-github-bot committed Jun 6, 2022
1 parent a23fe45 commit f05ad8b
Show file tree
Hide file tree
Showing 14 changed files with 145 additions and 375 deletions.
4 changes: 0 additions & 4 deletions Facebook.Unity.Editor/android/ManifestMod.cs
Expand Up @@ -38,8 +38,6 @@ public class ManifestMod
public const string UnityDialogsActivityName = "com.facebook.unity.FBUnityDialogsActivity";
public const string UnityGameRequestActivityName = "com.facebook.unity.FBUnityGameRequestActivity";
public const string UnityGamingServicesFriendFinderActivityName = "com.facebook.unity.FBUnityGamingServicesFriendFinderActivity";
public const string UnityGameGroupCreateActivityName = "com.facebook.unity.FBUnityCreateGameGroupActivity";
public const string UnityGameGroupJoinActivityName = "com.facebook.unity.FBUnityJoinGameGroupActivity";
public const string ApplicationIdMetaDataName = "com.facebook.sdk.ApplicationId";
public const string AutoLogAppEventsEnabled = "com.facebook.sdk.AutoLogAppEventsEnabled";
public const string AdvertiserIDCollectionEnabled = "com.facebook.sdk.AdvertiserIDCollectionEnabled";
Expand Down Expand Up @@ -156,8 +154,6 @@ public static void UpdateManifest(string fullPath)

ManifestMod.AddSimpleActivity(doc, dict, ns, DeepLinkingActivityName, true);
ManifestMod.AddSimpleActivity(doc, dict, ns, UnityGameRequestActivityName);
ManifestMod.AddSimpleActivity(doc, dict, ns, UnityGameGroupCreateActivityName);
ManifestMod.AddSimpleActivity(doc, dict, ns, UnityGameGroupJoinActivityName);

// add the app id
// <meta-data android:name="com.facebook.sdk.ApplicationId" android:value="\ fb<APPID>" />
Expand Down
16 changes: 0 additions & 16 deletions Facebook.Unity.Tests/Editor/MockEditor.cs
Expand Up @@ -58,22 +58,6 @@ public void Init()
callback(new ResultContainer(result));
}

public void ShowGameGroupCreateMockDialog(
Utilities.Callback<ResultContainer> callback,
string callbackId)
{
var result = MockResults.GetGroupCreateResult(int.Parse(callbackId), this.ResultExtras);
callback(new ResultContainer(result));
}

public void ShowGameGroupJoinMockDialog(
Utilities.Callback<ResultContainer> callback,
string callbackId)
{
var result = MockResults.GetGenericResult(int.Parse(callbackId), this.ResultExtras);
callback(new ResultContainer(result));
}

public void ShowPayMockDialog(
Utilities.Callback<ResultContainer> callback,
string callbackId)
Expand Down
2 changes: 1 addition & 1 deletion Facebook.Unity.Tests/Mobile/Android/Init.cs
Expand Up @@ -29,7 +29,7 @@ public class Init : Facebook.Unity.Tests.Init
{
protected override void CallInit(InitDelegate callback)
{
((AndroidFacebook)this.Mock.Facebook).Init("123456789", null, callback);
((AndroidFacebook)this.Mock.Facebook).Init("123456789", "token", null, callback);
}
}
}
1 change: 1 addition & 0 deletions Facebook.Unity/FB.cs
Expand Up @@ -314,6 +314,7 @@ public static void Init(InitDelegate onInitComplete = null, HideUnityDelegate on
{
((AndroidFacebook)FB.facebook).Init(
appId,
clientToken,
onHideUnity,
onInitComplete);
};
Expand Down
2 changes: 2 additions & 0 deletions Facebook.Unity/Mobile/Android/AndroidFacebook.cs
Expand Up @@ -125,6 +125,7 @@ public override string SDKVersion

public void Init(
string appId,
string clientToken,
HideUnityDelegate hideUnityDelegate,
InitDelegate onInitComplete)
{
Expand All @@ -139,6 +140,7 @@ public override string SDKVersion

var args = new MethodArguments();
args.AddString("appId", appId);
args.AddString("clientToken", clientToken);
var initCall = new JavaMethodCall<IResult>(this, "Init");
initCall.Call(args);
this.userID = this.androidWrapper.CallStatic<string>("GetUserID");
Expand Down
14 changes: 0 additions & 14 deletions Facebook.Unity/PlatformEditor/EditorWrapper.cs
Expand Up @@ -53,20 +53,6 @@ public void Init()
this.ShowEmptyMockDialog(callback, callbackId, "Mock App Request");
}

public void ShowGameGroupCreateMockDialog(
Utilities.Callback<ResultContainer> callback,
string callbackId)
{
this.ShowEmptyMockDialog(callback, callbackId, "Mock Game Group Create");
}

public void ShowGameGroupJoinMockDialog(
Utilities.Callback<ResultContainer> callback,
string callbackId)
{
this.ShowEmptyMockDialog(callback, callbackId, "Mock Game Group Join");
}

public void ShowPayMockDialog(
Utilities.Callback<ResultContainer> callback,
string callbackId)
Expand Down
8 changes: 0 additions & 8 deletions Facebook.Unity/PlatformEditor/IEditorWrapper.cs
Expand Up @@ -33,14 +33,6 @@ internal interface IEditorWrapper
Utilities.Callback<ResultContainer> callback,
string callbackId);

void ShowGameGroupCreateMockDialog(
Utilities.Callback<ResultContainer> callback,
string callbackId);

void ShowGameGroupJoinMockDialog(
Utilities.Callback<ResultContainer> callback,
string callbackId);

void ShowPayMockDialog(
Utilities.Callback<ResultContainer> callback,
string callbackId);
Expand Down

0 comments on commit f05ad8b

Please sign in to comment.