Add the python interpreter as a hidden dep of a pex file #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@JakobDegen Do you know anyone who can review this? |
|
I'll import it and try and find someone. Sorry for letting this slip a bit, I've been traveling and so it's a bit harder to keep up with everything going on |
|
@JakobDegen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
to facebook/buck2-prelude
that referenced
this pull request
May 3, 2024
Summary: We have a unique python setup. We distribute it hermetically via an internal tool (similar to dotslash), then we set up our `python` toolchain to return a `PythonToolchainInfo` whose `interpreter` and `host_interpreter` fields point to a shell script called `python_shim.sh` that is created via `ctx.actions.write()`, in order to properly set up the venv and do some other things to make it hermetic. Later, if you call `python_binary`, it generates a pex file which contains a line like this at the beginning: ``` #!/usr/bin/env buck-out/v2/gen/toolchains/48291db568f0aab5-9e2be58768776d78/__python__/python_shim.sh ``` Presently this is broken because the `cmd_args` to execute the pex file does not have an action dependency on the interpreter, and so it complains that it cannot find `python_shim.h`. This PR makes it work X-link: facebook/buck2#626 Reviewed By: IanChilds Differential Revision: D56844063 Pulled By: JakobDegen fbshipit-source-id: 69b68f7a0884d645203bf8b199be5c0b97cacef7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a unique python setup. We distribute it hermetically via an internal tool (similar to dotslash), then we set up our
pythontoolchain to return aPythonToolchainInfowhoseinterpreterandhost_interpreterfields point to a shell script calledpython_shim.shthat is created viactx.actions.write(), in order to properly set up the venv and do some other things to make it hermetic.Later, if you call
python_binary, it generates a pex file which contains a line like this at the beginning:Presently this is broken because the
cmd_argsto execute the pex file does not have an action dependency on the interpreter, and so it complains that it cannot findpython_shim.h. This PR makes it work