Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add the python interpreter as a hidden dep of a pex file (#626)
Summary: We have a unique python setup. We distribute it hermetically via an internal tool (similar to dotslash), then we set up our `python` toolchain to return a `PythonToolchainInfo` whose `interpreter` and `host_interpreter` fields point to a shell script called `python_shim.sh` that is created via `ctx.actions.write()`, in order to properly set up the venv and do some other things to make it hermetic. Later, if you call `python_binary`, it generates a pex file which contains a line like this at the beginning: ``` #!/usr/bin/env buck-out/v2/gen/toolchains/48291db568f0aab5-9e2be58768776d78/__python__/python_shim.sh ``` Presently this is broken because the `cmd_args` to execute the pex file does not have an action dependency on the interpreter, and so it complains that it cannot find `python_shim.h`. This PR makes it work Pull Request resolved: #626 Reviewed By: IanChilds Differential Revision: D56844063 Pulled By: JakobDegen fbshipit-source-id: 69b68f7a0884d645203bf8b199be5c0b97cacef7
- Loading branch information