#1526-fix sed issues on MAC OS X

[doflink]

fixes #1526 1526
I have tested with python 2.7.10

[ploxiln]

    platform = run("uname")
    print("platform=%r" % platform)

shows exactly platform='Darwin' for me, on OS X 10.11.6, what does it show for you?

[bitprophet]

Same here on Sierra (10.12.3) re: it still just being "Darwin". Not sure what else would be causing this PR to make the functionality work, though. Extra whitespace? We'll definitely need to see what @doflink's uname looks like :)

[doflink]

Hi,
when I convert platform to string and print out, it shows also "Darwin". However, when I write it to a file, it shows "^[(B^[[mDarwin". There is a special character in front of "Darwin" in my case.
Thanks.

[bitprophet]

Likely some shell related artifact, since the value comes out of a run('uname'). Wonder if trying harder to avoid that in the run() (e.g. use_shell=False or similar; or stripping nonprinting characters; etc) is more appropriate than the in test; honestly not sure. It's not like a system with Darwin in its uname that is not OS X is likely at all...

[ploxiln]

It does look like something is adding some terminal escape codes - running without shell and/or pty is a good idea to try. (I'm pretty sure "uname" itself never does that, unless "uname" on your system is something besides the stock /usr/bin/uname).

run("uname", shell=False, pty=False)

Maybe also make sure the output of which uname is /usr/bin/uname.

[doflink]

I agree. Your solution is much better.