contrib.sed(): avoid shell for uname #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some (uncommon) systems can end up with shell escapes in the output
of run("uname"), so don't use shell (or pty), they're not needed anyway.
|
+1 on disabling shell/pty for this sort of background call. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some (uncommon) systems can end up with shell escapes in the output
of run("uname"), so don't use shell (or pty), they're not needed anyway.
fixes #1526 / #1527
Figured this was another very easy little "fix". I'm happy to re-target to whatever branch is desired.
There is an integration test for
contrib.sed()(already), which should be a reasonable sanity-test that I didn't break it...