New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dark mode for website #1382
Comments
Sounds awesome! I look forward to your contribution! |
Hello @MehfoozurRehman , I noticed that you opened this issue three months ago about adding dark mode. I'm interested in contributing to the project and was wondering if you are still working on this issue or if you would be willing to let me take a look at it? Please let me know if there's anything I can do to help. |
Hey @dougwilson, is this issue still open? If yes, can you please assign me this issue? |
Fixes expressjs#1382 Sometimes it creates eye strain when you are learning form a white backgrounded documentation since 4 to 6 hours a day. That is why, I removed that white background image and the website is looking very good now.
What's pending here? |
Hey everyone, Apologies for my absence last year due to studies. I'm comfortable with the MERN stack but not Ruby. However, I use Express.js daily and am eager to implement dark mode. Can someone guide me on running the project locally? I'm ready to contribute. Thanks, |
ok so last year I tried doing the local run according to repo readme and again today i tried but its giving me this error for some reason to make sure it's not my local pc i am using GitHub code spaces. these is the result of first steps I am not really familiar with the ruby ecosystem so please let me know what i am doing wrong. |
and i have read the issues created based on this one so what i am thinking once i have this running locally the area where i have marked red i am thinking of adding these two icons first there can be some js to check the user device preference and adjust the theme according to that and if a user switches the theme, we save the preference in local storage. also i have read the concern about removing the background image from body i will make sure i pick the background color from that image for the light mode |
Hey Guys, was this still active? And/or still being worked on? I'm looking to make some contributions here. |
@chrisdel101 Please do.... I haven't delved into this issue, but if you can sort it out your contribs are welcome! |
okay, I'm looking into this and will plan to handle it. |
- init commit - add darkmode.css file and include
- add darkmode icon - add darkmmode JS file after body
guys can someone please help me run the repo locally |
Hey, just read the /README.md#local-setup |
i have sent this before the instructions in readme are not working for me please can you help here |
i have tried on github codespaces and my local computer its the same |
@MehfoozurRehman I've already started working on this, see above, and have made some significant progress. Prob not worth you also working on at this point. If you are set on it, I am making this as a "theme", meaning there could be numerous themes. So after I complete PR this you could add another "theme". Like GH has multiple dark themes? |
@chrisdel101, it's okay. Please continue working on this. I was under the impression that this issue was abandoned, but if you can, please complete the pull request. |
Re: your setup, the images above are not showing up for me. After you install Jekyll and run the serve command what happens? |
Huh, yeah I have no idea why you are getting that. Seems like something is not intstalled correctly, or a gem is missing. I assume you did all these steps first: If something failed in the first two steps then the server will fail. Maybe try the example in the docs they give and see you can run the basic example there. You should have something like this before it will run
Install extra gem from Then after cloning/forking the expressJS repo, this is what I see:
|
- futher changes to dark mode CSS for index - futher changes to dark mode JS for index
- add hover state styles - complete most of index page
- init commit - add darkmode.css file and include
- add darkmode icon - add darkmmode JS file after body
- futher changes to dark mode CSS for index - futher changes to dark mode JS for index
- add hover state styles - complete most of index page
Hey guys, I ran into a problem.
This is the
I get The overall point is all the pages need that Update-- Status: working now. |
- Get page layout script tag path to work - clean out CSS to nest under body.dark-mode
- add styles for hello-world, routing, generator - hello-world not possible to style iframe
- complete all CSS for all Getting Started pages
- add all script tags - finish JS file - finish all CSS for pages
- fix whitespace
- add css to search bar drop down - rearrange css file and add comments
- add check for local storage
- add hover color on search bar results - fix search bar width on FR, DE, RU, UZ pages caused by adding moon icon to navbar
- remove error line css - add system style check - remove local storage use until toggled
- clean up comments in theme js - wrap system theme check in function
* Issue ##1382 - init commit - add darkmode.css file and include * Issue ##1382 - add darkmode icon - add darkmmode JS file after body * Issue ##1382: work on JS and CSS * Issue ##1382 - futher changes to dark mode CSS for index - futher changes to dark mode JS for index * Issue ##1382 - add hover state styles - complete most of index page * Issue ##1382 - Get page layout script tag path to work - clean out CSS to nest under body.dark-mode * Issue ##1382 - add styles for hello-world, routing, generator - hello-world not possible to style iframe * Issue #1382 - complete all CSS for all Getting Started pages * Issue #1382 - add all script tags - finish JS file - finish all CSS for pages * issue #1382 - fix whitespace * issue #1382 - add css to search bar drop down - rearrange css file and add comments * issue #1382 - add check for local storage * issue #1382 -add css to add header html * issue #1382 - add hover color on search bar results - fix search bar width on FR, DE, RU, UZ pages caused by adding moon icon to navbar * issue #1382 - remove error line css - add system style check - remove local storage use until toggled * issue #1382 - clean up comments in theme js - wrap system theme check in function * Issue #1490 - remove bands on dropdowns - slight fix to first "installing" drop down * Issue #1490 - rejig JS - add listener to mediaQuery - make latest change be the override * Issue #1490 - fix forgotten merge conflict line in header uz & ru
Fixed with #1490 |
would like to help here with making a dark theme for expressjs.com
The text was updated successfully, but these errors were encountered: