Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix : Added a media query for dark mode users #1428

Closed
wants to merge 2 commits into from
Closed

Fix : Added a media query for dark mode users #1428

wants to merge 2 commits into from

Conversation

YashNuhash
Copy link

Fixes #1382

@YashNuhash
Fix: Removed background image form style.css
5d7ffd6 
Fixes expressjs#1382

Sometimes it creates eye strain when you are learning form a white backgrounded documentation since 4 to 6 hours a day. 
That is why, I removed that white background image and the website is looking very good now.
@YashNuhash
Fix : Added a media query to make conditional for dark mode users
26db309 
Fixes expressjs#1382
@YashNuhash
Copy link
Author

YashNuhash commented Jun 14, 2023 •
edited

Hey, @dougwilson

Now, you can review my commit

@YashNuhash YashNuhash changed the title Fix : Added a media query to make conditional for dark mode users Fix : Added a media query for dark mode users Jun 14, 2023
YashNuhash
YashNuhash commented Jun 14, 2023
View reviewed changes
Copy link
Author

@YashNuhash YashNuhash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all about the changes that I made here.

css/style.css
@@ -14,7 +14,7 @@

body {
font: 400 14px/1.6 "Open Sans", sans-serif;
background: url(/images/bg.jpg);
background: url(/images/bg.jpg);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added background

YashNuhash
YashNuhash commented Jun 14, 2023
View reviewed changes
css/style.css
@@ -669,6 +669,12 @@ footer {

}

@media (prefers-color-scheme:dark) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added media query

@crandmck crandmck added the UI Change, update, or fix for site UI (not content) label Mar 5, 2024
@crandmck
Copy link
Member

crandmck commented May 4, 2024

@chrisdel101 Should this be closed or merged?

@chrisdel101
Copy link
Contributor

chrisdel101 commented May 4, 2024 •
edited

This would have handled the system setting, but only changed the main background. So closed since #1490 handles this a bit differently.
(ps - reopen if I closed prematurely :) )

@chrisdel101 chrisdel101 closed this May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
UI Change, update, or fix for site UI (not content)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YashNuhash @crandmck @chrisdel101