Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
- clean up comments in theme js
- wrap system theme check in function
  • Loading branch information
chrisdel101 committed Apr 22, 2024
1 parent 6c016b5 commit bfb5f5c
Showing 1 changed file with 11 additions and 8 deletions.
19 changes: 11 additions & 8 deletions js/theme.js
@@ -1,13 +1,12 @@
// system theme check
if (window.matchMedia && window.matchMedia('(prefers-color-scheme: dark)').matches) {
if (systemDarkMode()) {
if(!hasLocalStorage()) {
darkModeOn()
// remove icon - cannot turn off
// remove icon - toggle not supported
document.querySelector('#theme-icon-container').remove()
darkModeOn()
} else {
// no use local storage til required
const isDarkMode = localStorage.getItem('darkmode')
// unless toggled off, darkmode is on
// unless toggled off, dark scheme is on
isDarkMode === 'false' ? darkModeOff()
: darkModeOn()
document.querySelector('.theme-toggle')
Expand All @@ -21,7 +20,7 @@ if (window.matchMedia && window.matchMedia('(prefers-color-scheme: dark)').match
.querySelector('.theme-toggle')
.addEventListener('click', toggleTheme)
} else {
// remove theme-toggle icon
// remove icon - toggle not supported
document.querySelector('#theme-icon-container').remove()
}
}
Expand All @@ -34,9 +33,10 @@ function toggleTheme(e) {
} else if (isDarkMode === 'false') {
localStorage.setItem('darkmode', 'true')
darkModeOn()
// isDarkMode stilll undefined
// local storage not used until now so
// isDarkMode still undefined
} else {
// need to check state
// need to check page state
if(darkModeState()) {
localStorage.setItem('darkmode', 'false')
darkModeOff()
Expand All @@ -58,3 +58,6 @@ function darkModeState() {
function hasLocalStorage() {
return typeof Storage !== 'undefined'
}
function systemDarkMode() {
return window.matchMedia && window.matchMedia('(prefers-color-scheme: dark)').matches
}

0 comments on commit bfb5f5c

Please sign in to comment.