Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in docs #13466

Merged
merged 3 commits into from Apr 29, 2024
Merged

Fix typos in docs #13466

merged 3 commits into from Apr 29, 2024

Conversation

strickvl
Copy link
Contributor

Fixed typos in Spacy docs.

Would be happy to add in a GH CI actions that automates this and catches these pre-emptively as part of this PR, but thought maybe that's a bit invasive into your codebase so just starting with the typos fixes first.

@svlandeg svlandeg added the docs Documentation and website label Apr 29, 2024
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks a lot for this PR!

It looks like the CI is failing with an unrelated error, which we'll look into separately.
Otherwise I think the only thing left to do is run prettier on the docs that have changed, cf this setup guide.

@strickvl strickvl requested a review from svlandeg April 29, 2024 08:14
@svlandeg svlandeg removed their request for review April 29, 2024 08:46
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing all these typos! Super appreciated. PR looks good to me.

I've also fixed the CI with this PR in the meantime: #13469

@svlandeg svlandeg merged commit 045cd43 into explosion:master Apr 29, 2024
9 checks passed
svlandeg added a commit that referenced this pull request Apr 29, 2024
* fix typos

* prettier formatting

---------

Co-authored-by: svlandeg <svlandeg@github.com>
@strickvl strickvl deleted the docs/fix-typos branch April 29, 2024 09:24
jordankanter pushed a commit to jordankanter/spaCy that referenced this pull request May 3, 2024
* fix typos

* prettier formatting

---------

Co-authored-by: svlandeg <svlandeg@github.com>
jordankanter pushed a commit to jordankanter/spaCy that referenced this pull request May 10, 2024
* fix typos

* prettier formatting

---------

Co-authored-by: svlandeg <svlandeg@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation and website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants