Fix single click on cells #181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this fix still necessary with the latest version of the library? I think some changes were made regarding this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue which caused the single click listener not to being triggered.
The problem appears when clicking onto a cell (no matter if header or not).
It can be reproduced by launching the example project and single-clicking onto a cell: a Toast will appear incorrectly indicating that a long click has been performed.
The checks using
mGestureDetector.onTouchEvent(e)aren't necessary intoAbstractItemClickListenersubclasses because the methods in which are used are called during amGestureDetector.onTouchEvent(e)invocation, started from theonInterceptTouchEventmethod of theAbstractItemClickListener.