Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Conversion to Godot 4.2 #75

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

[WIP] Conversion to Godot 4.2 #75

wants to merge 31 commits into from

Conversation

ephread
Copy link
Owner

@ephread ephread commented Sep 6, 2023

Complete conversion to Godot 4.2.

It's in pretty good shape and usable, but still a work in progress because I want to take advantage of the new static properties.

Will update this PR as I go.

This was referenced Sep 6, 2023
@mttkay
Copy link

mttkay commented Nov 18, 2023

@ephread Amazing work! Regarding the open issue:

I want to take advantage of the new static properties

Is this just an internal refactor or does it materially affect a game's integration with inkgd? If it's the former, would there be value in already merging your work to the main branch and make it the default work stream so folks can start using it in their games?

I think this would help getting more eyes on functionality and code earlier, and regressions can be found more quickly. WDYT?

I haven't personally started migrating my game to Godot 4 yet because inkgd is the primary logic driver in my game so it's a bit of a catch-22 for me.

Has anyone else already started integrating against this branch? I think @francoisdlt has already?

@francoisdlt
Copy link
Contributor

Yes I have started using the godot4 branch in production. So far so good !

@ephread ephread changed the title [WIP] Conversion to Godot 4.1.1 [WIP] Conversion to Godot 4.2 Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants