Add @requires_webgpu, make WebGPU tests fail if unavailable #21870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes these tests safer so they won't just silently pass if you happen to run against a browser/system where WebGPU isn't available (currently including Chrome on Linux and Firefox/Safari).
sbc100
approved these changes
May 1, 2024
sbc100
reviewed
May 1, 2024
|
@sbc100 tests seem good now, could you force merge? thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes these tests safer so they won't just silently pass if you happen to run against a browser/system where WebGPU isn't available (currently including Chrome on Linux and Firefox/Safari).
Verified these 6 tests fail without WebGPU support, using:
EMTEST_BROWSER='/Applications/Google\ Chrome\ Canary.app/Contents/MacOS/Google\ Chrome\ Canary --disable-gpu' test/runner.py 'browser.test_webgpu*'And that they're skipped when prepending
EMTEST_LACKS_WEBGPU=1to that.(
--disable-gpuhas the side effect of disabling WebGPU since we don't ship a software fallback in Chrome right now.)