New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement wgpuAdapterGetLimits, add test that limit requests are applied #21799
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WebGPU isn't available on the test VMs so you'll need to exit cleanly if WebGPU isn't available, similar to the neighboring test:
if (status == WGPURequestAdapterStatus_Unavailable) { |
Ah, right, I missed that webGPU might not be available - fixed it :) |
… required limits - move code filling WGPULimits structs into func - use from wgpuAdapterGetLimits and wgpuDeviceGetLimits - rewrite test case for required limit to check if supported limits match requested limits - add missing field maxBufferSize when requesting device
Figured this should fix all comments, so I replied here rather than indiviually. Implemented binding for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you! And nice catch on maxBufferSize
.
@sbc100 the remaining failure is happening on |
Happy to force merge this. Could you prepare to good commit message in the PR description. The current on I get if I merge now would be:
I'm not sure which parts are relevent. |
@sbc100 Yes, good idea. I've rewritten the PR title and summary, please use those.
|
Fixes #21798