Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new build-config package #9292

Merged
merged 23 commits into from May 13, 2024
Merged

feat: add new build-config package #9292

merged 23 commits into from May 13, 2024

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Mar 25, 2024

playing around with a new package to centralize configuration and allow us to ship v2 addons. currently the approach won't work because package presence requires either addon-main's to report into global config they are present (which then introduces timing bugs) or for configuration to somehow run from the perspective of the consuming addons.

This removes all HAS_PACKAGE checks which while something we wanted to do may prematurely cause us a ton of grief due to how poorly embroider/macros works with pnpm hardlinks

TODO (not necessarily in this PR)

  • move feature list into build-config
  • move deprecation list into build-config
  • move debugging list into build-config
  • convert all addons to v2
  • convert all packages to eslint flat config
  • convert all tests to eslint flat config
  • get blueprints working again
  • get addon-test-support working again
  • fixup app re-exports
  • fix usage of private types
  • fix test-apps
  • eliminate private-build-infra addon
  • dont use assert from @ember/debug

  • remove exports stripping from publish script
  • change to using extensions in addon files
  • rollup types
  • prevent breaking change by having ember-data addon always set global config

@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ chore This PR primarily refactors code or updates dependencies labels Apr 12, 2024
@runspired runspired force-pushed the v2-addon-config branch 2 times, most recently from 832f317 to 923e871 Compare April 21, 2024 21:49
@runspired runspired force-pushed the v2-addon-config branch 3 times, most recently from 8d58041 to 3caf328 Compare April 30, 2024 18:16
@runspired runspired marked this pull request as ready for review May 3, 2024 08:11
@runspired runspired force-pushed the v2-addon-config branch 4 times, most recently from 295a82e to 90ae168 Compare May 12, 2024 19:12
@runspired runspired merged commit fd497de into main May 13, 2024
18 checks passed
@runspired runspired deleted the v2-addon-config branch May 13, 2024 08:20
@runspired runspired mentioned this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 canary PR is targeting canary (default) 🏷️ chore This PR primarily refactors code or updates dependencies
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant