New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new build-config package #9292
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
runspired
force-pushed
the
v2-addon-config
branch
from
April 12, 2024 08:28
9e254d1
to
b16af2f
Compare
runspired
added
🎯 canary
PR is targeting canary (default)
🏷️ chore
This PR primarily refactors code or updates dependencies
labels
Apr 12, 2024
runspired
force-pushed
the
v2-addon-config
branch
from
April 13, 2024 09:44
f4f1c90
to
29baf5d
Compare
This was referenced Apr 14, 2024
runspired
force-pushed
the
v2-addon-config
branch
from
April 18, 2024 18:12
3607b1b
to
4b596fb
Compare
This was referenced Apr 18, 2024
Merged
Merged
runspired
force-pushed
the
v2-addon-config
branch
2 times, most recently
from
April 21, 2024 21:49
832f317
to
923e871
Compare
runspired
force-pushed
the
v2-addon-config
branch
3 times, most recently
from
April 30, 2024 18:16
8d58041
to
3caf328
Compare
runspired
force-pushed
the
v2-addon-config
branch
4 times, most recently
from
May 12, 2024 19:12
295a82e
to
90ae168
Compare
runspired
force-pushed
the
v2-addon-config
branch
from
May 12, 2024 20:07
90ae168
to
99ef400
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
playing around with a new package to centralize configuration and allow us to ship v2 addons. currently the approach won't work because package presence requires either addon-main's to report into global config they are present (which then introduces timing bugs) or for configuration to somehow run from the perspective of the consuming addons.
This removes all HAS_PACKAGE checks which while something we wanted to do may prematurely cause us a ton of grief due to how poorly embroider/macros works with pnpm hardlinks
TODO (not necessarily in this PR)