-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full support for esm flat configs #1834
Comments
@runspired which package manager are you using? If you use yarn you are very likely affect by: yarnpkg/berry#6219 If you don't use yarn, can you please provide me with a GitHub repository I can clone with a minimal setup that demos this. I do have a mjs test case here so it work in principal: |
@dbaeumer pnpm monorepo, this branch has the work in it: emberjs/data#9292 |
I am also using "eslint.config.mjs" in the root of my repo and this extension fails to find it. The "type" field in the "package.json" file is module, and it still doesn't work:
|
@Zamiell which version are you using. Falt config support need currently 3.0.5-pre-release version of the eslint extension. |
@runspired after removing
Anything I am missing? |
@dbaeumer I'll try that out! |
@dbaeumer indeed removing that from config seems to make everything work as expected! If we want our editor to report unused directives now, how do we go about that? |
sorry, i didn't understand that. i have linting working now on the alpha version, sorry for the noise.
historically in the ecosystem people have used this: https://github.com/eslint-community/eslint-plugin-eslint-comments |
change to
|
Currently this extension appears to only find eslint configuration files when:
eslint.config.cjs
eslint.config.js
with"type": "module"
in package.jsonIt currently does not appear to find configuration files when:
eslint.config.js
without"type": "module"
in package.jsoneslint.config.mjs
Other things to note:
v3.0.5 (pre-release)
"eslint.useFlatConfig": true,
@babel/eslint-parser
@babel/eslint-plugin: Support ESLint 9 babel/babel#16220)The text was updated successfully, but these errors were encountered: