Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Canvas] Update limits and change some imports #182028

Merged
merged 3 commits into from Apr 30, 2024

Conversation

ThomThomson
Copy link
Contributor

@ThomThomson ThomThomson commented Apr 29, 2024

Summary

This PR updates the limits.yml to reflect that Canvas is actually much smaller than it appears. Also did some small changes to the imports which looks like it shaves off .1kb from the page load. This PR also lowers the dashboard plugin's limit to be more inline with the actual size of the Dashboard plugin.

@ThomThomson
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #1 / FilePreview pressing escape calls closePreview
  • [job] [logs] FTR Configs #72 / Rule execution logic API Detection Engine - Execution logic @ess @serverless @serverlessQA Machine learning type rules "before all" hook for "should create 1 alert from ML rule when record meets anomaly_threshold"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
canvas 1228 1227 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.1MB 1.1MB -4.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
canvas 14.1KB 14.0KB -117.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
canvas 32 31 -1

Total ESLint disabled count

id before after diff
canvas 36 35 -1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson added loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Feature:Canvas labels Apr 30, 2024
@ThomThomson ThomThomson marked this pull request as ready for review April 30, 2024 12:03
@ThomThomson ThomThomson requested review from a team as code owners April 30, 2024 12:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
code review only

@ThomThomson ThomThomson merged commit 5ea747c into elastic:main Apr 30, 2024
30 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels Apr 30, 2024
yuliacech pushed a commit to yuliacech/kibana that referenced this pull request May 3, 2024
updates the `limits.yml` to reflect that Canvas is actually _much_ smaller than it appears.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants