[Canvas] Update limits and change some imports (#182028)

updates the `limits.yml` to reflect that Canvas is actually _much_ smaller than it appears.
elastic · Apr 30, 2024 · 5ea747c · 5ea747c
1 parent 4b4c573
commit 5ea747c
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 10 deletions.
diff --git a/packages/kbn-optimizer/limits.yml b/packages/kbn-optimizer/limits.yml
@@ -8,7 +8,7 @@ pageLoadAssetSize:
   assetManager: 25000
   banners: 17946
   bfetch: 22837
-  canvas: 1066647
+  canvas: 29355
   cases: 180037
   charts: 55000
   cloud: 21076
@@ -25,7 +25,7 @@ pageLoadAssetSize:
   core: 435325
   crossClusterReplication: 65408
   customIntegrations: 22034
-  dashboard: 82025
+  dashboard: 52967
   dashboardEnhanced: 65646
   data: 454087
   datasetQuality: 50624

diff --git a/x-pack/plugins/canvas/common/lib/constants.ts b/x-pack/plugins/canvas/common/lib/constants.ts
@@ -5,10 +5,11 @@
  * 2.0.
  */
 
-// eslint-disable-next-line @kbn/imports/no_boundary_crossing
-import { SHAREABLE_RUNTIME_NAME } from '../../shareable_runtime/constants_static';
 import { FilterField } from '../../types';
 
+// avoid import from shareable_runtime
+const SHAREABLE_RUNTIME_NAME = 'kbn_canvas';
+
 export const CANVAS_TYPE = 'canvas-workpad';
 export const CUSTOM_ELEMENT_TYPE = 'canvas-element';
 export const TEMPLATE_TYPE = `${CANVAS_TYPE}-template`;

diff --git a/x-pack/plugins/canvas/public/index.ts b/x-pack/plugins/canvas/public/index.ts
@@ -5,10 +5,10 @@
  * 2.0.
  */
 
-import { PluginInitializerContext } from '@kbn/core/public';
-import { CoreStart } from '@kbn/core/public';
-import { CanvasServices } from './services';
-import { CanvasSetup, CanvasStart, CanvasStartDeps, CanvasPlugin } from './plugin';
+import type { PluginInitializerContext } from '@kbn/core/public';
+import type { CoreStart } from '@kbn/core/public';
+import type { CanvasServices } from './services';
+import { type CanvasSetup, type CanvasStart, type CanvasStartDeps, CanvasPlugin } from './plugin';
 
 export type { CanvasSetup, CanvasStart };
 

diff --git a/x-pack/plugins/canvas/public/lib/loading_indicator.ts b/x-pack/plugins/canvas/public/lib/loading_indicator.ts
@@ -5,8 +5,8 @@
  * 2.0.
  */
 
-import * as Rx from 'rxjs';
 import { CoreStart } from '@kbn/core/public';
+import { BehaviorSubject } from 'rxjs';
 
 let isActive = false;
 
@@ -15,7 +15,7 @@ export interface LoadingIndicatorInterface {
   hide: () => void;
 }
 
-const loadingCount$ = new Rx.BehaviorSubject(0);
+const loadingCount$ = new BehaviorSubject(0);
 
 export const initLoadingIndicator = (addLoadingCount: CoreStart['http']['addLoadingCountSource']) =>
   addLoadingCount(loadingCount$);