Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Using PropsWithChildren type #182008

Merged
merged 5 commits into from Apr 30, 2024
Merged

[ML] Using PropsWithChildren type #182008

merged 5 commits into from Apr 30, 2024

Conversation

jgowdyelastic
Copy link
Member

Following up on #181257, adding PropsWithChildren to the types which were missed.

@jgowdyelastic jgowdyelastic self-assigned this Apr 29, 2024
@jgowdyelastic jgowdyelastic added chore :ml release_note:skip Skip the PR/issue when compiling release notes v8.15.0 labels Apr 29, 2024
@jgowdyelastic jgowdyelastic marked this pull request as ready for review April 29, 2024 16:28
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner April 29, 2024 16:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic jgowdyelastic mentioned this pull request Apr 29, 2024
Merged
@qn895
Copy link
Member

qn895 commented Apr 30, 2024

LGTM 🎉

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #55 / serverless observability UI Dataset Quality Dataset quality flyout goes to log explorer for degraded docs when show all is clicked

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit 6023164 into elastic:main Apr 30, 2024
19 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 30, 2024
yuliacech pushed a commit to yuliacech/kibana that referenced this pull request May 3, 2024
@jgowdyelastic @yuliacech
[ML] Using PropsWithChildren type (elastic#182008)
daa18fc 
Following up on elastic#181257, adding `PropsWithChildren` to the types which
were missed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qn895 qn895 qn895 approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
backport:skip This commit does not require backporting chore :ml release_note:skip Skip the PR/issue when compiling release notes v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jgowdyelastic @elasticmachine @qn895 @kibana-ci @kibanamachine