Add explicit children types #181257

patrykkopycinski · 2024-04-21T17:25:17Z

Summary

Prep work for React@18 bump

tl;dr In React@18 React.FC doesn't contain children anymore, so in order to make the bump easier I have decided to split the effort in multiple faces and hopefully this will make it easier for everyone

This PR focuses only on adding explicit children declaration either by using React.PropsWithChildren type or by adding children: React.ReactNode to the existing props types

DefinitelyTyped/DefinitelyTyped#46691

patrykkopycinski · 2024-04-21T17:25:25Z

/ci

…-fix'

patrykkopycinski · 2024-04-21T20:06:20Z

/ci

PhilippeOberti

desk tested and code LGTM for the Threat Intelligence Investigations team! Thanks for making this changes!

nikitaindik

Thanks for the changes @patrykkopycinski! I have checked the types and can confirm that changes cause no issues with our current version of React. Approving on behalf of "security-detection-rule-management".

Couple questions:

Why is children optional in some cases and required in others?
What's the next step for v18 upgrade? Do we need to upgrade Kibana simultaneously with EUI so that they are compatible?

jloleysens

Core changes LGTM

…-fix'

patrykkopycinski · 2024-04-29T10:09:46Z

Thank you for the feedback @jgowdyelastic @cnasikas @nikitaindik , I have aligned all the changes to use PropsWithChildren

...cation/data_frame_analytics/pages/analytics_creation/components/details_step/description.tsx

x-pack/plugins/ml/public/application/components/page_header/page_header.tsx

cnasikas

ResponseOps changes LGTM!

…s/analytics_creation/components/details_step/description.tsx Co-authored-by: James Gowdy <jgowdy@elastic.co>

…bana into chore/react-18-props # Conflicts: # x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/components/details_step/description.tsx

kibana-ci · 2024-04-29T13:01:19Z

💚 Build Succeeded

Buildkite Build
Commit: d4f5d2b
Storybooks Preview
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-181257-d4f5d2b3d5d5
Observability Deployment

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/cell-actions`	46	44	-2
`@kbn/react-kibana-mount`	7	8	+1
`@kbn/search-api-panels`	81	82	+1
`spaces`	65	66	+1
total			+1

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id	before	after	diff
`@kbn/i18n-react`	0	1	+1
`@kbn/ml-url-state`	1	2	+1
`esUiShared`	3	4	+1
`presentationUtil`	2	3	+1
total			+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`enterpriseSearch`	2.7MB	2.7MB	+77.0B
`uiActionsEnhanced`	135.7KB	135.7KB	+10.0B
total			+87.0B

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id	before	after	diff
`module count`	-	5874	+5874
`total size`	-	6.7MB	+6.7MB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`infra`	102.5KB	102.5KB	+13.0B
`kibanaReact`	40.3KB	40.3KB	+4.0B
`spaces`	25.6KB	25.6KB	+11.0B
total			+28.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/cell-actions`	64	56	-8
`@kbn/react-kibana-mount`	10	11	+1
`@kbn/search-api-panels`	81	82	+1
`spaces`	256	257	+1
total			-5

History

💚 Build #206531 succeeded 0eb3bc1
💔 Build #206515 failed 4aa30ad
💛 Build #205336 was flaky 3e45f64
💔 Build #205227 failed db47ea9
💚 Build #205094 succeeded 604f507

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @patrykkopycinski

jgowdyelastic

There are still quite a lot of places in the ML code where PropsWithChildren can be used rather than children?: React.ReactNode.
But to not hold up this PR I'll approve and I'll fix them in a follow up.

…ges (#182014) ## Summary Original problem: `PropsWithChildren` require a generic type parameter (there's no default). This was not made visible in the merged PR, because we had type-checking on the PRs temporarily (accidentally) removed. Thsi PR fixes the fallout from #181257 => Errors: https://buildkite.com/elastic/kibana-on-merge/builds/44454

Following up on #181257, adding `PropsWithChildren` to the types which were missed.

## Summary Prep work for React@18 bump tl;dr In React@18 `React.FC` doesn't contain `children` anymore, so in order to make the bump easier I have decided to split the effort in multiple faces and hopefully this will make it easier for everyone This PR focuses only on adding explicit `children` declaration either by using `React.PropsWithChildren` type or by adding `children: React.ReactNode` to the existing props types DefinitelyTyped/DefinitelyTyped#46691 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Sergi Massaneda <sergi.massaneda@gmail.com> Co-authored-by: Marco Vettorello <marco.vettorello@elastic.co> Co-authored-by: James Gowdy <jgowdy@elastic.co>

…ges (elastic#182014) ## Summary Original problem: `PropsWithChildren` require a generic type parameter (there's no default). This was not made visible in the merged PR, because we had type-checking on the PRs temporarily (accidentally) removed. Thsi PR fixes the fallout from elastic#181257 => Errors: https://buildkite.com/elastic/kibana-on-merge/builds/44454

Following up on elastic#181257, adding `PropsWithChildren` to the types which were missed.

Add explicit children types

343db0d

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

831d9ab

…-fix'

patrykkopycinski self-assigned this Apr 21, 2024

Merge branch 'main' into chore/react-18-props

b5e1ca8

patrykkopycinski marked this pull request as ready for review April 22, 2024 13:59

patrykkopycinski requested review from a team as code owners April 22, 2024 13:59

stephmilovic approved these changes Apr 23, 2024

View reviewed changes

PhilippeOberti approved these changes Apr 23, 2024

View reviewed changes

nikitaindik approved these changes Apr 25, 2024

View reviewed changes

jloleysens approved these changes Apr 26, 2024

View reviewed changes

patrykkopycinski and others added 3 commits April 29, 2024 08:14

cleanup types

4aa30ad

fix

3aa3e1e

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

0eb3bc1

…-fix'

botelastic bot added the ci:project-deploy-observability Create an Observability project label Apr 29, 2024

jgowdyelastic reviewed Apr 29, 2024

View reviewed changes

...cation/data_frame_analytics/pages/analytics_creation/components/details_step/description.tsx Outdated Show resolved Hide resolved

jgowdyelastic reviewed Apr 29, 2024

View reviewed changes

x-pack/plugins/ml/public/application/components/page_header/page_header.tsx Outdated Show resolved Hide resolved

cnasikas approved these changes Apr 29, 2024

View reviewed changes

patrykkopycinski and others added 3 commits April 29, 2024 14:02

Update x-pack/plugins/ml/public/application/data_frame_analytics/page…

eae8afc

…s/analytics_creation/components/details_step/description.tsx Co-authored-by: James Gowdy <jgowdy@elastic.co>

fix

8112b26

Merge branch 'chore/react-18-props' of github.com:patrykkopycinski/ki…

d4f5d2b

…bana into chore/react-18-props # Conflicts: # x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/components/details_step/description.tsx

patrykkopycinski enabled auto-merge (squash) April 29, 2024 14:06

jgowdyelastic approved these changes Apr 29, 2024

View reviewed changes

patrykkopycinski merged commit 0780c19 into elastic:main Apr 29, 2024
47 checks passed

kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels Apr 29, 2024

jgowdyelastic mentioned this pull request Apr 29, 2024

[ML] Using PropsWithChildren type #182008

Merged

patrykkopycinski added the v8.14.0 label Apr 29, 2024

delanni mentioned this pull request Apr 29, 2024

[Fix] fix type issues from unparameterized PropsWithChildren type usages #182014

Merged

jgowdyelastic added a commit that referenced this pull request Apr 30, 2024

[ML] Using PropsWithChildren type (#182008)

6023164

Following up on #181257, adding `PropsWithChildren` to the types which were missed.

yuliacech pushed a commit to yuliacech/kibana that referenced this pull request May 3, 2024

[ML] Using PropsWithChildren type (elastic#182008)

daa18fc

Following up on elastic#181257, adding `PropsWithChildren` to the types which were missed.

kibanamachine mentioned this pull request May 23, 2024

Replace usage of Get API keys endpoint with Query API keys endpoint for API keys grid page #168970

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add explicit children types #181257

Add explicit children types #181257

patrykkopycinski commented Apr 21, 2024 •

edited

patrykkopycinski commented Apr 21, 2024

patrykkopycinski commented Apr 21, 2024

PhilippeOberti left a comment

nikitaindik left a comment

jloleysens left a comment

patrykkopycinski commented Apr 29, 2024

cnasikas left a comment

kibana-ci commented Apr 29, 2024 •

edited

API count

jgowdyelastic left a comment •

edited

Add explicit children types #181257

Add explicit children types #181257

Conversation

patrykkopycinski commented Apr 21, 2024 • edited

Summary

patrykkopycinski commented Apr 21, 2024

patrykkopycinski commented Apr 21, 2024

PhilippeOberti left a comment

Choose a reason for hiding this comment

nikitaindik left a comment

Choose a reason for hiding this comment

jloleysens left a comment

Choose a reason for hiding this comment

patrykkopycinski commented Apr 29, 2024

cnasikas left a comment

Choose a reason for hiding this comment

kibana-ci commented Apr 29, 2024 • edited

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Any counts in public APIs

Async chunks

Canvas Sharable Runtime

Page load bundle

API count

History

jgowdyelastic left a comment • edited

Choose a reason for hiding this comment

patrykkopycinski commented Apr 21, 2024 •

edited

kibana-ci commented Apr 29, 2024 •

edited

jgowdyelastic left a comment •

edited