Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[License-Workflow] Fail workflow on automated vetting-requests #328

Merged
merged 1 commit into from Mar 17, 2024
Merged

[License-Workflow] Fail workflow on automated vetting-requests #328

merged 1 commit into from Mar 17, 2024

Commits on Mar 17, 2024

  1. [License-Workflow] Fail workflow on automated vetting-requests 

    Since eclipse#220 license-reviews
are automatically requested for PRs created by dependabot. But in that
change the logic of the 'Process license check results' step was not
updated to consider that case. This had the effect that the
license-vetting workflow always succeeded for PRs created by dependabot.

The intention to not fail the workflow in general when a license-review
was requested is because initially review-request were only created
manually from committers by adding a corresponding comment to the PR.
And that workflow execution should not fail respectively its result was
actually irrelevant.

Fixes eclipse-tycho/tycho#3661
    @HannesWell
    HannesWell committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    0fc9381 View commit details
    Browse the repository at this point in the history