[License-Workflow] Fail workflow on automated vetting-requests #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
force-pushed
the
fail-on-automated-vetting-requests
branch
2 times, most recently
from
a3ee170
to
3a7cf77
Compare
Since eclipse#220 license-reviews are automatically requested for PRs created by dependabot. But in that change the logic of the 'Process license check results' step was not updated to consider that case. This had the effect that the license-vetting workflow always succeeded for PRs created by dependabot. The intention to not fail the workflow in general when a license-review was requested is because initially review-request were only created manually from committers by adding a corresponding comment to the PR. And that workflow execution should not fail respectively its result was actually irrelevant. Fixes eclipse-tycho/tycho#3661
HannesWell
force-pushed
the
fail-on-automated-vetting-requests
branch
from
3a7cf77
to
0fc9381
Compare
|
All testing was successful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #220 license-reviews are automatically requested for PRs created by dependabot. But in that change the logic of the 'Process license check results' step was not updated to consider that case. This had the effect that the license-vetting workflow always succeeded for PRs created by dependabot.
The intention to not fail the workflow in general when a license-review was requested is because initially review-request were only created manually from committers by adding a corresponding comment to the PR. And that workflow execution should not fail respectively its result was actually irrelevant.
Fixes eclipse-tycho/tycho#3661