Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check crate MSRVs #1026

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

Conversation

fuzzypixelz
Copy link
Member

This add a check for the MSRV of all crates in the workspace. Each crate has its own MSRV specified through package.rust-version.

@fuzzypixelz fuzzypixelz marked this pull request as draft May 14, 2024 12:19
@fuzzypixelz fuzzypixelz marked this pull request as draft May 14, 2024 12:19
@fuzzypixelz fuzzypixelz added enhancement Existing things could work better internal Changes not included in the changelog labels May 24, 2024
@fuzzypixelz fuzzypixelz changed the title Check MSRV Check crate MSRVs May 27, 2024
@Mallets
Copy link
Member

Mallets commented May 28, 2024

@fuzzypixelz what's the status of this PR? Is it ready for review?

@fuzzypixelz
Copy link
Member Author

@fuzzypixelz what's the status of this PR? Is it ready for review?

Right now it seems to report incorrect MSRVs. I would have to investigate that first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Existing things could work better internal Changes not included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants