Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add check-labels workflow to CI jobs #1025

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

diogomatsubara
Copy link
Contributor

To easy the generation of changelogs we're enforcing labels on PRs. In eclipse-zenoh/ci#128 a new re-usable workflow was added to check and this PR enables the check.

@diogomatsubara diogomatsubara marked this pull request as draft May 14, 2024 07:59
@diogomatsubara diogomatsubara force-pushed the ci-check-labels branch 3 times, most recently from 5a127c9 to dc5f1e2 Compare May 14, 2024 09:06
To easy the generation of changelogs we're enforcing labels on PRs. In
eclipse-zenoh/ci#128 a new re-usable workflow
was added to check and this PR enables the check.
@diogomatsubara diogomatsubara changed the title Add check-labels workflow to CI jobs fix: add check-labels workflow to CI jobs May 14, 2024
@Mallets
Copy link
Member

Mallets commented May 28, 2024

@diogomatsubara is this PR still alive?

@diogomatsubara
Copy link
Contributor Author

@Mallets yes, still needed. I left in draft for now because we need some operational things to happen before we can start enforcing the check-labels check. By default, people that makes PR from forked branches can't edit the labels for their own PRs. The solution for this is to give those contributors triage permissions on the eclipse-zenoh org. This is done, unfortunately manually, via the Eclipse PMI interface and only Eclipse committers can add new people to the contributors list. Those contributors need to have an eclipse account, signed the ECA and have added their github ID to the eclipse account settings. The instructions to add those contributors to the Eclipse PMI can be found here: https://www.eclipse.org/projects/handbook/#pmi-contributors.

I'll ping you with a list of emails to add to the PMI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants