Added validate-exports script to check the consistency of package exports #1269
Conversation
| "exclude": [ | ||
| "../src/test/**/*" | ||
| ] | ||
| } |
There was a problem hiding this comment.
That's very smart 🎩
I'm just confused by the name and location of the file. What about
tsconfig.src-main.json, tsconfig.src-main-only.json, tsconfig.src-plain.json, tsconfig.src-plain-only.json? (to have it in line with the other tsconfigs).
I would love to see a comment like
// only used for validating to not import modules from 'src/test', ... within base modules like 'src/parser/*'
in line 1 😉
There was a problem hiding this comment.
I'm just confused by the name and location of the file. What about
tsconfig.src-main.json, tsconfig.src-main-only.json, tsconfig.src-plain.json, tsconfig.src-plain-only.json? (to have it in line with the other tsconfigs).
I'd prefer to keep it separate to highlight that this is part of the framework tests and that it's not used for building. Having too many tsconfigs next to each other could be confusing.
I would love to see a comment like `// only used for validating to not import modules from 'src/test', ... within base modules like 'src/parser/*' in line 1 😉
I got an error in the JSON editor when I added a comment (comments are not part of the standard JSON syntax).
There was a problem hiding this comment.
That's another pro arg for renaming, as tsconfig. ... .json files are handling differently. With such a name comments are permitted, see
There was a problem hiding this comment.
Ok, renamed and added a comment. I still think it's better to keep the file in a subfolder to avoid confusion.
spoenemann
force-pushed
the
spoenemann/enforce-isolation-of-1261
branch
from
61346d6
to
445cccc
Compare
Fixes #1261.
#1171 and #1258 should be adapted to include additional exports validation and update the exclude paths of main.