-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
moved generator API to a dedicated package export, solves #1285 #1287
Conversation
46e00ef
to
08562c0
Compare
Thanks! Refactoring langium-cli is great, I had that on my mind for quite some time. Regarding the name: I agree Then I'd also rename |
08562c0
to
5fc85ef
Compare
Right, switched to
Done 馃憤 |
5fc85ef
to
134c8ff
Compare
Nice work with replacing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Please modify the main package export test so it excludes the generate
code (see #1269).
134c8ff
to
dc7c9d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are lots of compile errors at the moment. I don't know why the GitHub Action wasn't triggered.
83292cd
to
a812c24
Compare
I missed to update an import of I would like to merge this PR ASAP, I left a hint in tsconfig.export-main.json, see packages/langium/test/tsconfig.export-main.json |
* move NEWLINE_REGEXP from 'template-string.ts' to 'regex-util.ts', * refactored our generators to use 'expandToNode' and friends instead of instantiating 'CompositeGeneratorNodes'
a812c24
to
2087e96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃殌
I named the new export
generating
, as its content is to be used for generating code.generators
may also work.generator
is IMO a bit misleading as there is no langium generator, andgeneration
means something different. 馃槈I took the opportunity to: