Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove now unsuitable arch attributes in equinox.core.sdk feature #573

Merged
merged 1 commit into from Mar 29, 2024

Conversation

HannesWell
Copy link
Member

@HannesWell HannesWell commented Mar 29, 2024

Now that the o.e.equinox.security.win32 fragment is architecture independent (because it is implemented through JNA) restricting it to one arch when including it in features is not necessary anymore.

This was forgotten in PR #564

Copy link

github-actions bot commented Mar 29, 2024

Test Results

   28 files  ±0     28 suites  ±0   11m 20s ⏱️ +3s
2 170 tests ±0  2 124 ✅ ±0  46 💤 ±0  0 ❌ ±0 
2 242 runs  ±0  2 196 ✅ ±0  46 💤 ±0  0 ❌ ±0 

Results for commit 5cb4412. ± Comparison against base commit dee9f0f.

♻️ This comment has been updated with latest results.

Now that the o.e.equinox.security.win32 fragment is architecture
independent (because it is implemented through JNA) restricting it to
one arch when including it in features is not necessary anymore.

This was forgotten in PR
eclipse-equinox#564
@HannesWell HannesWell merged commit e28b81b into eclipse-equinox:master Mar 29, 2024
27 of 28 checks passed
@HannesWell HannesWell deleted the remove-arch-attribute branch March 29, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant