New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Windows on Arm64 (WoA). #559
base: master
Are you sure you want to change the base?
Conversation
@chirontt thanks for bringing this forward, in SWT we used (eclipse) linked folders to make the same sources available for different fragements, would something like this be suitable for the WoA fragemnt as well so we don't need an additional intermediate? |
Test Results 3 files - 25 3 suites - 25 24s ⏱️ - 11m 16s Results for commit ba48051. ± Comparison against base commit a6ad93f. This pull request removes 2156 tests.
♻️ This comment has been updated with latest results. |
Yes, it may be doable. The benefits will be to remove the new |
@laeubi I've done what you suggested, but I encounter some small hiccup: how to include the
but the resulting
but then the resulting
and it almost achieves what I want, but the resulting Is there a better way? Otherwise I'd use the |
@chirontt I also looked into this and in order to simplify the Would you be interested in looking into this in a separate PR? If not, I can do it. |
@HannesWell Yes, using JNA is a good idea, better than these clunky JNI/C files with re-compile for various platforms. But I have no experience with JNA, so please go ahead and see if JNA is applicable here. Once JNA is proven to work, there are other places in https://github.com/eclipse-platform/eclipse.platform/tree/master/resources/bundles/org.eclipse.core.filesystem/natives |
Absolutely. It looks good, see #564.
The filesystem-access implemented in The situation for Therefore my suggestion is to first focus on the absolute requirements, namely SWT and the Equinox-Launcher. |
bf27f2a
to
196f9c4
Compare
Branch updated with the latest from master, with PR description updated as well. |
A new launcher fragment for WoA is added: 'org.eclipse.equinox.launcher.win32.win32.aarch64' Various features are also updated to include the new fragment. To build the Equinox launcher binaries for WoA: On a WoA box, run the following commands: cd features\org.eclipse.equinox.executable.feature\library\win32 ant clean build_eclipse -Dnative=win32.win32.aarch64 -Dos=win32 -Dws=win32 -Darch=aarch64 and the following launcher binaries for WoA are generated in the current directory: eclipse.exe eclipse_11900.dll eclipsec.exe These WoA binaries need be manually moved over to the 'equinox.binaries' repo, to their correct directories as followed: org.eclipse.equinox.executable\bin\win32\win32\aarch64\eclipse.exe org.eclipse.equinox.executable\bin\win32\win32\aarch64\eclipsec.exe org.eclipse.equinox.launcher.win32.win32.aarch64\eclipse_11900.dll
196f9c4
to
ba48051
Compare
Add support for Windows on Arm64 (WoA)
A new launcher fragment for WoA is added:
org.eclipse.equinox.launcher.win32.win32.aarch64
Various features are also updated to include the new fragment.
To build the Equinox launcher binaries for WoA
On a WoA box, run the following commands:
and the following launcher binaries for WoA are generated in the current directory:
These WoA binaries need be manually moved over to the equinox.binaries repo, to their correct directories there as followed: