Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump docker ubuntu jammy #1933

Merged
merged 3 commits into from Mar 12, 2024
Merged

Bump docker ubuntu jammy #1933

merged 3 commits into from Mar 12, 2024

Conversation

e-tmplr
Copy link
Contributor

@e-tmplr e-tmplr commented Feb 21, 2024

Use Ubuntu Jammy (LTS) for the docker images because that provides a version of CMake that is required to build the project

  • Updated README.md accordingly
  • Enable building the examples in build.sh
  • Remove the docker containers on exit

@e-tmplr e-tmplr mentioned this pull request Feb 21, 2024
Open
eboasson
eboasson approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@eboasson eboasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @e-tmplr. I apologise for the long delay, I have been away for a bit and it has been a bit hectic these past weeks ...

The CI failures have totally unrelated (known) causes.

@eboasson eboasson merged commit dcd6eba into eclipse-cyclonedds:master Mar 12, 2024
15 of 21 checks passed
@e-tmplr e-tmplr deleted the bump-docker-ubuntu-jammy branch April 3, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eboasson eboasson eboasson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@e-tmplr @eboasson