Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support storing and applying of memory content #96

Merged
merged 7 commits into from Mar 13, 2024

Commits on Mar 12, 2024

  1. Support storing and applying of memory content

    Add commands to store and apply memory content as Intel HEX file
    - Encapsulate behavior in new MemoryStorage class
    - Trigger 'store' from Memory view, Variables view and command palette
    - Trigger 'apply' from Memory view, Explorer view and command palette
    - Use nrf-intel-hex library for read/write file licensed under BSD-3
    
    Use quick inputs to guide user through necessary input
    - Initialize as much of the input as possible through command args
    
    Communicate with webview through messenger requests and notifications
    -- Request to trigger store and apply from webview
    -- Notify webview about any written memory so it can update properly
    
    Minor improvements
    - Move some common types and functionality into 'common' area
    - Avoid bleeding Debug Adapter types into webview, use messaging types
    - Common style: 'getVariables' -> 'getVariablesType'
    - Provide utility functions and types for debug requests
    - Fix 'Enter' handling for numpad by checking key value of event
    
    Closes eclipse-cdt-cloud#50
    martin-fleck-at committed Mar 12, 2024
    Copy the full SHA
    281c374 View commit details
    Browse the repository at this point in the history
  2. Consider PR feedback

    - Move evaluation expression for addressOf and sizeOf to adapter
    - Make 'toHexStringWithRadixMarker' more flexible
    - Shorten validation messages for memory
    - Align props and method names with existing method names, no prefixes
    - Replace 'MemoryVariableNode' with 'IVariablesContext'
    - Add comment on overlap calculation
    - Make sure command enablement fails early
    martin-fleck-at committed Mar 12, 2024
    Copy the full SHA
    04b97a9 View commit details
    Browse the repository at this point in the history
  3. PR Feedback: Disable store/apply memory buttons if not possible

    - VS Code always allows to execute a command programmatically
    -- There is no way to determine whether a command is enabled or not
    
    - Forward current session context to memory inspector
    martin-fleck-at committed Mar 12, 2024
    Copy the full SHA
    53248da View commit details
    Browse the repository at this point in the history
  4. Further enhancements: Context menu, memory event, PR feedback

    - Integrate commands with context menu
    - React to 'memory' event from debug adapter
    - Use 'Store Memory to File' as proper storage label
    - Use workspace folder as default save location
    - Minor fix for numpad key enter on memory options
    martin-fleck-at committed Mar 12, 2024
    Copy the full SHA
    4b0c003 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Add further PR feedback

    - Use short (PascalCase) names for generic arguments
    - Adapt copyright header in debug-requests
    - Remove optional 'count' parameter in messaging and memory-provider
    - Remove caching of session context and simply re-create if necessary
    - Execute variable queries in parallel instead of sequentially
    - Fix typo in comment
    martin-fleck-at committed Mar 13, 2024
    Copy the full SHA
    83c51b5 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    175a330 View commit details
    Browse the repository at this point in the history
  3. Improve address handling and support decimal addresses

    - Provide decimal address regex and function to extract address
    - Ensure we can properly serialize bigints when logging data
    - Ensure we return a proper variable range if we only have the address
    martin-fleck-at committed Mar 13, 2024
    Copy the full SHA
    edf986d View commit details
    Browse the repository at this point in the history