Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve styling of column resize handles #92

Merged
merged 1 commit into from Mar 6, 2024

Conversation

martin-fleck-at
Copy link
Contributor

@martin-fleck-at martin-fleck-at commented Mar 5, 2024

What it does

  • Only show resize divider on table header
  • Use same color for resize divider as for dividers of data

resize-handles

Closes #71

How to test

  • Start up any memory inspector and try it out ;-)

Review checklist

Reminder for reviewers

@martin-fleck-at
Copy link
Contributor Author

Edit: Rebased after #81:

resize-handles

@jreineckearm
Copy link
Contributor

Looks good! Is it possible to keep the divider from drawing over the "load more" button areas? But rather a nit as I understand this may complicate things a little.

@martin-fleck-at
Copy link
Contributor Author

@jreineckearm I could do it for the top part but it is very hard to do for the bottom part since the height of the divider is calculated automatically and set on the element directly. If this is very important for you, I can look into this more deeply but it will probably be a scripting solution as I don't think we can do this with CSS alone. Let me know :-)

@jreineckearm
Copy link
Contributor

@martin-fleck-at , I think top only would already be a great improvement. I think what confused me initially was that the always visible divider in the column headers grew beyond its top when clicked. Addressing the bottom would rather be a nice to have in future. :-)

- Only show resize divider on table header
- Use same color for resize divider as for dividers of data

Closes eclipse-cdt-cloud#71
@martin-fleck-at
Copy link
Contributor Author

@jreineckearm Sure, I pushed an update and now it looks like this, I hope this is what you envisioned:

enhanced-resize

@colin-grant-work colin-grant-work merged commit 7b4c3bf into eclipse-cdt-cloud:main Mar 6, 2024
5 checks passed
@jreineckearm
Copy link
Contributor

Great! Thanks, @martin-fleck-at ! Much better and doesn't feel "jumpy" anymore. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve styling / visual feedback for changing column sizes in memory view
3 participants