Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auto-refresh capabilities for memory inspector windows #115

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add auto-refresh capabilities for memory inspector windows #115

wants to merge 3 commits into from

Commits on Apr 29, 2024

  1. Extend Auto Refresh capabilities with 'After Delay' and 'On Focus' 

    - Rework 'refreshOnStop' boolean setting to 'autoRefresh' enumerable
-- On Stop (previously: 'on' for 'refreshOnStop'
-- On Focus (previously: always implicit on view state change)
-- After Delay (new)
-- Off (previously: 'off' for 'refreshOnStop')

- On Stop
-- Rework global setting to be local for each Memory Inspector
-- Listen to debug session stopped event and propagate to view

- On Focus
-- Rework implicit refresh update to option in setting
-- Listen to view state changes and propagate to view

- After Delay
-- New option to explicitly define a delay when re-fetching the memory
-- Minimum: 500ms, default: 500, input step size: 250ms

Refactoring:
- Split debug session tracking into dedicated class with session events
-- Convert debug events into session events with additional data
- Split context tracking from memory provider into dedicated class
- Move manifest to common for default values and avoid duplication
-- Align 'Min' with 'Minimal' value from manifest

Minor:
- Add title toolbar item for C/C++ file to access open memory inspector
- Improve debugging experience by using inline source maps
- Align creation of option enums to use const objects
- Additionally guard 'body' on debug responses for safety
- Avoid functional React state update where unnecessary

Fixes eclipse-cdt-cloud#91
    @martin-fleck-at
    martin-fleck-at committed Apr 29, 2024
    Copy the full SHA
    1424d24 View commit details
    Browse the repository at this point in the history

  2. PR Feedback 

    - Improve wording in setting descriptions
- Move shared types into common area instead of using type imports
- Fix 'fetchMemory' not returning the correct promise
    @martin-fleck-at
    martin-fleck-at committed Apr 29, 2024
    Copy the full SHA
    b04a3cf View commit details
    Browse the repository at this point in the history

  3. PR Feedback: Separate refresh options and remove 'On Focus' 

    Also remove the show memory inspector toolbar item for C/C++ files
    @martin-fleck-at
    martin-fleck-at committed Apr 29, 2024
    Copy the full SHA
    b6da870 View commit details
    Browse the repository at this point in the history