Sort all imports

[colin-grant-work]

What it does

Fixes #98

I don't have strong feelings about import ordering, but I do have strong feelings about extraneous lines in a diff, and some people have local setups that automatically sort imports in different ways. This PR introduces lint rules that should enforce deterministic ordering of imports and applies them across the code base so that in the future, we should have a common standard for import ordering and we shouldn't run into cases where a PR spontaneously introduces a new order.

Others may have strong feelings: they may want a different order, or not want these lint rules at all. Please speak up if so.

How to test

1. This shouldn't do anything but reorder a bunch of imports, so if CI passes, it's probably fine.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[martin-fleck-at]

Looks good to me, thank you Colin!

[planger]

Thanks @colin-grant-work!

I also don't have any hard feelings about the concrete order of imports. To me the most important aspect is that we don't need to care about the order, unnecessary imports and don't introduce noise when we run "Organize Imports" locally. Because I personally rarely edit the imports manually, I just run quick fixes to add imports and then "Organize Import".

So I actually would propose to also enable organizing the imports on save in the settings.json and make sure this works nicely with the respective eslint config:

{
  "editor.formatOnSave": true,
  "editor.codeActionsOnSave": {
    "source.fixAll.eslint": "explicit",
    "source.organizeImports": "explicit"
  },
  "eslint.validate": [
    "javascript",
    "typescript"
  ],
}

To make this work locally, I needed to slightly adjust the settings in the errors.eslintrc.json (see inline suggestion) and then run another npm run lint --fix. After that everything seemed to work nicely for me locally.

We may want to consider to add the vscode-eslint extension as a recommendation for the workspace.

{
    "recommendations": [
        "dbaeumer.vscode-eslint"
    ]
}

What do you think?

[planger]

Thank you @colin-grant-work! It now works fine when retrying with a cleanly started VS Code (see comment above).