Refactor Item Properties View to use table components #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implentation of the item properties view uses <p> tags with no styling to display the properties. This looks ok but can be significantly improved by showing the properties in a table. This commit makes the following changes: - Reuses filter tree component for item properties view. - Added option to hide filler columns/cells - Ability to render a table cell value as an element - Added tooltips for item properties entries Signed-off-by: Neel Gondalia <ngondalia@blackberry.com>
ngondalia
force-pushed
the
UpdateItemPropsView
branch
from
88211aa
to
3d2ee18
Compare
|
|
bhufmann
approved these changes
May 21, 2024
This was referenced May 22, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implentation of the item properties view shows properties as plaintext with no styling. This looks ok but can be significantly improved by showing the properties in a table.
This commit makes the following changes:
Signed-off-by: Neel Gondalia ngondalia@blackberry.com