This repository has been archived by the owner on May 7, 2020. It is now read-only.
[UI] Charts: New white theme and small improvements #4368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New chart theme `white` * Better DPI based calculations for chart padding and legend line width * Revised chart stroking options Signed-off-by: Holger Reichert <mail@h0lger.de>
|
Well, build is failing due to unrelated test failures |
kaikreuzer
approved these changes
Oct 3, 2017
|
Now hue tests are failing. Should I rebase or something? |
|
All good, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new
whitechart theme and some small improvements.Follow-up to #4291
New chart theme
whiteCurrently there are 3 chart themes: bright, dark, black
This PR completes the list with a new
whitetheme, so that the following themes are available:Rendering with
theme=white:Better DPI based calculations
With high resolutions and high DPI values, the padding and the legend line widths were not calculated correctly. This resulted in chopped off and/or overlapping axis labels. The calculation is now based on the DPI value.
Revised chart stroking options
With high DPI values, the chart strokes looked a bit ugly. Fixed with better parameters for the
BasicStrokeBefore:
After:
