Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support new screen mode 'promptBreakageForm' #149

Merged
merged 1 commit into from
May 7, 2024

Conversation

shakyShane
Copy link
Collaborator

@shakyShane shakyShane commented Apr 29, 2024

https://app.asana.com/0/0/1207195637811331/f

Description:

Added a new screen mode, promptBreakageForm. When the dashboard loads in this mode it will remove the toggle from the breakage form.

Steps to test this PR:

  • npm run preview
  • select the last option from the dropdown promptBreakageForm
  • The breakage form should load, but the toggle should be absent - it should look like this:

image.png

@shakyShane
Copy link
Collaborator Author

shakyShane commented Apr 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on Graphite Graphite

@shakyShane shakyShane marked this pull request as ready for review April 29, 2024 15:10
@shakyShane shakyShane force-pushed the 04-29-reflect_params_in_the_debugger branch from 140d6a0 to 1f69e7a Compare April 30, 2024 07:32
@shakyShane shakyShane force-pushed the 04-29-support_new_screen_mode_promptbreakageform_ branch from 90a1a7b to 4ca0135 Compare April 30, 2024 07:32
@shakyShane shakyShane force-pushed the 04-29-reflect_params_in_the_debugger branch from 1f69e7a to 40c07b8 Compare April 30, 2024 09:37
@shakyShane shakyShane force-pushed the 04-29-support_new_screen_mode_promptbreakageform_ branch from 4ca0135 to b765184 Compare April 30, 2024 09:37
@shakyShane shakyShane force-pushed the 04-29-reflect_params_in_the_debugger branch from 40c07b8 to c1dbb19 Compare April 30, 2024 12:09
@shakyShane shakyShane force-pushed the 04-29-support_new_screen_mode_promptbreakageform_ branch 2 times, most recently from c4c9f2a to 7d7e156 Compare May 7, 2024 08:16
@shakyShane shakyShane changed the base branch from 04-29-reflect_params_in_the_debugger to main May 7, 2024 08:16
@shakyShane shakyShane force-pushed the 04-29-support_new_screen_mode_promptbreakageform_ branch from 7d7e156 to 9f0a882 Compare May 7, 2024 13:48
Copy link

@jaceklyp jaceklyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by myself, works great!

@shakyShane shakyShane merged commit 25b8903 into main May 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants