reflect params in the debugger #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @shakyShane and the rest of your teammates on |
shakyShane
commented
Apr 29, 2024
| @@ -21,5 +21,5 @@ | |||
| "jsxFactory": "h", | |||
| "jsxFragmentFactory": "Fragment" | |||
| }, | |||
| "include": ["types.ts", "schema", "e2e", "scripts", "shared/js", "integration-tests", "guides"] | |||
| "include": ["types.ts", "schema", "e2e", "scripts", "shared/js", "integration-tests", "guides", "debugger"] | |||
There was a problem hiding this comment.
the debugger folder was previously missed (by mistake)
shakyShane
commented
Apr 29, 2024
Comment on lines
+39
to
+46
| let reflectList = ['screen'] | ||
| let reflectParams = new URLSearchParams(Object.entries({ state: initialState })) | ||
| for (let [key, value] of searchParams) { | ||
| if (reflectList.includes(key)) { | ||
| reflectParams.set(key, value) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This represents a set of keys that might be set on the outer debugger iframe. Anything in reflectList should be forwarded to each iframe instance
shakyShane
force-pushed
the
04-29-translations_for_prompt_breakage_screen
branch
from
a861e11
to
efffc8b
Compare
shakyShane
force-pushed
the
04-29-reflect_params_in_the_debugger
branch
from
140d6a0
to
1f69e7a
Compare
shakyShane
changed the base branch from
04-29-translations_for_prompt_breakage_screen
to
main
shakyShane
force-pushed
the
04-29-reflect_params_in_the_debugger
branch
from
1f69e7a
to
40c07b8
Compare
shakyShane
force-pushed
the
04-29-reflect_params_in_the_debugger
branch
from
40c07b8
to
c1dbb19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.asana.com/0/0/1207195637811329/f
TL;DR
Update debugger to reflect url parameters and fix initial state loading. This will be needed in the next PR to preview/debug another new screen.
What changed?
How to test?
npm run previewscreen-breakageForm, orscreen-toggleReportWhy make this change?
This change ensures the debugger reflects correct URL parameters - to mimic what the native applications do. Without this change, you could not load the dashboard in this state, making debugging more difficult