Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev settings to clear previously seen surveys so they can be tested again #4476

Merged
merged 1 commit into from May 9, 2024

Conversation

CDRussell
Copy link
Member

@CDRussell CDRussell commented Apr 26, 2024

Task/Issue URL: https://app.asana.com/0/0/1207179707350730/f

Description

Adds a dev setting to reset previous surveys so you can test taking the survey again.

Steps to test this PR

QA-optional since it's just dev settings. but steps to test are below:

  • Dismiss or view the autofill survey in autofill settings; verify the prompt to take the survey is gone
  • Visit the internal autofill dev settings (Settings->Autofill Dev Settings)
  • Scroll all the way to the bottom and tap on Previously Seen Surveys)
  • Return to autofill settings and verify the survey reappears

@CDRussell CDRussell force-pushed the feature/craig/autofill_survey_ui branch from 3d103c3 to 1464547 Compare April 26, 2024 14:17
@CDRussell CDRussell force-pushed the feature/craig/autofill_survey_dev_setting branch from 166194d to 1ddc690 Compare April 26, 2024 14:17
@CDRussell CDRussell force-pushed the feature/craig/autofill_survey_ui branch from 1464547 to f72f5e3 Compare April 26, 2024 14:50
@CDRussell CDRussell force-pushed the feature/craig/autofill_survey_dev_setting branch from 1ddc690 to faa3ef9 Compare April 26, 2024 14:50
@CDRussell CDRussell marked this pull request as ready for review April 26, 2024 15:04
@CDRussell CDRussell force-pushed the feature/craig/autofill_survey_ui branch from f72f5e3 to 1d47dc2 Compare April 26, 2024 15:13
@CDRussell CDRussell force-pushed the feature/craig/autofill_survey_dev_setting branch from faa3ef9 to 859ef2d Compare April 26, 2024 15:13
Comment on lines +66 to +68
prefs.edit {
remove(SURVEY_IDS)
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could also noop this code for anything that is not internal build.

Copy link
Collaborator

@aitorvs aitorvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one comment, works as expected.

@CDRussell CDRussell force-pushed the feature/craig/autofill_survey_ui branch 2 times, most recently from 9ad5518 to 8a642a7 Compare May 3, 2024 15:10
@CDRussell CDRussell force-pushed the feature/craig/autofill_survey_dev_setting branch from 859ef2d to bbd479e Compare May 3, 2024 15:10
@CDRussell CDRussell force-pushed the feature/craig/autofill_survey_ui branch from 8a642a7 to 52237ef Compare May 6, 2024 11:26
@CDRussell CDRussell force-pushed the feature/craig/autofill_survey_dev_setting branch from bbd479e to 2669c32 Compare May 6, 2024 11:26
@CDRussell CDRussell force-pushed the feature/craig/autofill_survey_ui branch from 52237ef to 50be897 Compare May 6, 2024 11:58
@CDRussell CDRussell force-pushed the feature/craig/autofill_survey_dev_setting branch from 2669c32 to 2839e1c Compare May 6, 2024 11:58
@CDRussell CDRussell force-pushed the feature/craig/autofill_survey_ui branch from 50be897 to ec725f9 Compare May 6, 2024 12:15
@CDRussell CDRussell force-pushed the feature/craig/autofill_survey_dev_setting branch from 2839e1c to f114d29 Compare May 6, 2024 12:15
@CDRussell CDRussell force-pushed the feature/craig/autofill_survey_ui branch from ec725f9 to c4dfe03 Compare May 7, 2024 16:31
@CDRussell CDRussell force-pushed the feature/craig/autofill_survey_dev_setting branch from f114d29 to ba3d582 Compare May 7, 2024 16:31
Copy link
Member Author

CDRussell commented May 9, 2024

Merge activity

  • May 9, 5:30 PM EDT: @CDRussell started a stack merge that includes this pull request via Graphite.
  • May 9, 5:45 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 9, 5:57 PM EDT: @CDRussell merged this pull request with Graphite.

@CDRussell CDRussell force-pushed the feature/craig/autofill_survey_ui branch from c4dfe03 to 3338184 Compare May 9, 2024 21:30
Base automatically changed from feature/craig/autofill_survey_ui to develop May 9, 2024 21:44
@CDRussell CDRussell force-pushed the feature/craig/autofill_survey_dev_setting branch from ba3d582 to 9dca554 Compare May 9, 2024 21:45
@CDRussell CDRussell merged commit 85e5c04 into develop May 9, 2024
5 checks passed
@CDRussell CDRussell deleted the feature/craig/autofill_survey_dev_setting branch May 9, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants