Add dev settings to clear previously seen surveys so they can be test…

…ed again
duckduckgo · Apr 26, 2024 · 166194d · 166194d
1 parent 3d103c3
commit 166194d
Show file tree

Hide file tree

Showing 4 changed files with 47 additions and 0 deletions.
diff --git a/.../java/com/duckduckgo/autofill/impl/ui/credential/management/survey/AutofillSurveyStore.kt b/.../java/com/duckduckgo/autofill/impl/ui/credential/management/survey/AutofillSurveyStore.kt
@@ -29,6 +29,7 @@ import kotlinx.coroutines.withContext
 interface AutofillSurveyStore {
     suspend fun hasSurveyBeenTaken(id: String): Boolean
     suspend fun recordSurveyWasShown(id: String)
+    suspend fun resetPreviousSurveys()
 }
 
 @ContributesBinding(AppScope::class)
@@ -60,6 +61,14 @@ class AutofillSurveyStoreImpl @Inject constructor(
         }
     }
 
+    override suspend fun resetPreviousSurveys() {
+        withContext(dispatchers.io()) {
+            prefs.edit {
+                remove(SURVEY_IDS)
+            }
+        }
+    }
+
     companion object {
         private const val PREFS_FILE_NAME = "autofill_survey_store"
         private const val SURVEY_IDS = "survey_ids"

diff --git a/...ternal/src/main/java/com/duckduckgo/autofill/internal/AutofillInternalSettingsActivity.kt b/...ternal/src/main/java/com/duckduckgo/autofill/internal/AutofillInternalSettingsActivity.kt
@@ -33,6 +33,7 @@ import com.duckduckgo.autofill.impl.configuration.AutofillJavascriptEnvironmentC
 import com.duckduckgo.autofill.impl.email.incontext.store.EmailProtectionInContextDataStore
 import com.duckduckgo.autofill.impl.store.InternalAutofillStore
 import com.duckduckgo.autofill.impl.store.NeverSavedSiteRepository
+import com.duckduckgo.autofill.impl.ui.credential.management.survey.AutofillSurveyStore
 import com.duckduckgo.autofill.internal.databinding.ActivityAutofillInternalSettingsBinding
 import com.duckduckgo.browser.api.UserBrowserProperties
 import com.duckduckgo.common.ui.DuckDuckGoActivity
@@ -83,6 +84,9 @@ class AutofillInternalSettingsActivity : DuckDuckGoActivity() {
     @Inject
     lateinit var autofillJavascriptEnvironmentConfiguration: AutofillJavascriptEnvironmentConfiguration
 
+    @Inject
+    lateinit var autofillSurveyStore: AutofillSurveyStore
+
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
         setContentView(binding.root)
@@ -132,6 +136,16 @@ class AutofillInternalSettingsActivity : DuckDuckGoActivity() {
         configureLoginsUiEventHandlers()
         configureNeverSavedSitesEventHandlers()
         configureAutofillJsConfigEventHandlers()
+        configureSurveyEventHandlers()
+    }
+
+    private fun configureSurveyEventHandlers() {
+        binding.autofillSurveyResetButton.setOnClickListener {
+            lifecycleScope.launch(dispatchers.io()) {
+                autofillSurveyStore.resetPreviousSurveys()
+            }
+            Toast.makeText(this, getString(R.string.autofillDevSettingsSurveySectionResetted), Toast.LENGTH_SHORT).show()
+        }
     }
 
     private fun configureNeverSavedSitesEventHandlers() = with(binding) {

diff --git a/autofill/autofill-internal/src/main/res/layout/activity_autofill_internal_settings.xml b/autofill/autofill-internal/src/main/res/layout/activity_autofill_internal_settings.xml
@@ -209,5 +209,24 @@
             app:primaryText="@string/autofillDevSettingsConfigDebugTitle"
             app:secondaryText="@string/autofillDevSettingsConfigDebugSubtitle" />
 
+        <com.duckduckgo.common.ui.view.divider.HorizontalDivider
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content" />
+
+        <com.duckduckgo.common.ui.view.listitem.SectionHeaderListItem
+            android:id="@+id/autofillSurveySectionTitle"
+            android:layout_width="match_parent"
+            android:layout_marginTop="20dp"
+            android:layout_height="wrap_content"
+            app:primaryText="@string/autofillDevSettingsSurveySectionTitle" />
+
+        <com.duckduckgo.common.ui.view.listitem.TwoLineListItem
+            android:id="@+id/autofillSurveyResetButton"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            app:primaryText="@string/autofillDevSettingsSurveySectionResetPreviousSurveysTitle"
+            app:secondaryText="@string/autofillDevSettingsSurveySectionInstruction" />
+
+
     </LinearLayout>
 </androidx.core.widget.NestedScrollView>
diff --git a/autofill/autofill-internal/src/main/res/values/donottranslate.xml b/autofill/autofill-internal/src/main/res/values/donottranslate.xml
@@ -69,4 +69,9 @@
     <string name="autofillDevSettingsAddSampleLoginsSameSubdomainSubtitle">Adds multiple logins for https://fill.dev with same username and password</string>
     <string name="autofillDevSettingsAddSampleLoginsMultipleSubdomains">Add duplicate logins (across different subdomains)</string>
     <string name="autofillDevSettingsAddSampleLoginsMultipleSubdomainsSubtitle">Adds multiple logins for https://fill.dev with same username and password but across different subdomains</string>
+
+    <string name="autofillDevSettingsSurveySectionTitle">Autofill Survey</string>
+    <string name="autofillDevSettingsSurveySectionResetPreviousSurveysTitle">Previously Seen Surveys</string>
+    <string name="autofillDevSettingsSurveySectionInstruction">Tap to reset available surveys</string>
+    <string name="autofillDevSettingsSurveySectionResetted">Previously seen surveys available again</string>
 </resources>